Feature/ci (#364)

* Add CI

* phpcbf

* phpcbf+mano

* visibility

* phpstan level 0

* phpstan level 1

* Add phpstan config

* Some phpstan lvl 2 fixes, won't be enforced

* Fix CI

.github/workflows/continuous-integration.yml

@@ -0,0 +1,31 @@
+name: "Continuous integration"
+
+on:
+  push:
+    branches:
+      - "master"
+    tags:
+       - "*"
+  pull_request:
+  schedule:
+    - cron: "0 0 * * *"
+  workflow_dispatch:
+
+jobs:
+  ci:
+    name: "GLPI ${{ matrix.glpi-version }} - php:${{ matrix.php-version }} - ${{ matrix.db-image }}"
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - {glpi-version: "10.0.x", php-version: "7.4", db-image: "mysql:5.7"}
+          - {glpi-version: "10.0.x", php-version: "8.0", db-image: "mysql:8.0"}
+          - {glpi-version: "10.0.x", php-version: "8.1", db-image: "mariadb:10.2"}
+          - {glpi-version: "10.0.x", php-version: "8.2", db-image: "mariadb:11.0"}
+          - {glpi-version: "10.0.x", php-version: "8.3-rc", db-image: "mysql:8.0"}
+    uses: "glpi-project/plugin-ci-workflows/.github/workflows/continuous-integration.yml@v1"
+    with:
+      plugin-key: "genericobject"
+      glpi-version: "${{ matrix.glpi-version }}"
+      php-version: "${{ matrix.php-version }}"
+      db-image: "${{ matrix.db-image }}"

.phpcs.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0"?>
+<ruleset>
+    <file>.</file>
+    <exclude-pattern>/.git/</exclude-pattern>
+    <exclude-pattern type="relative">^vendor/</exclude-pattern>
+
+    <arg name="colors" />
+    <arg name="extensions" value="php" />
+    <arg value="p" />
+    <arg name="warning-severity" value="0" />
+
+    <rule ref="PSR12">
+        <exclude name="Generic.Files.LineLength" />
+        <exclude name="PSR1.Classes.ClassDeclaration.MissingNamespace" />
+    </rule>
+    <rule ref="Generic.Arrays.ArrayIndent"></rule>
+</ruleset>

composer.json

@@ -3,7 +3,10 @@
         "php": ">=7.4"
     },
     "require-dev": {
-        "glpi-project/tools": "^0.6"
+        "glpi-project/tools": "^0.7.1",
+        "php-parallel-lint/php-parallel-lint": "^1.3",
+        "phpstan/phpstan": "^1.10",
+        "squizlabs/php_codesniffer": "^3.7"
     },
     "config": {
         "optimize-autoloader": true,

front/commondropdown.form.php

@@ -28,17 +28,16 @@
  * -------------------------------------------------------------------------
  */
 
-include ("../../../inc/includes.php");
+include("../../../inc/includes.php");
 
 if (isset($_REQUEST['itemtype'])) {
-   $itemtype = $_REQUEST['itemtype'];
-   if (class_exists($itemtype)) {
-      $dropdown = new $itemtype();
-      include (GLPI_ROOT . "/front/dropdown.common.form.php");
-   } else {
-      Html::displayErrorAndDie(__('The requested dropdown does not exists', 'genericobject'));
-   }
+    $itemtype = $_REQUEST['itemtype'];
+    if (class_exists($itemtype)) {
+        $dropdown = new $itemtype();
+        include(GLPI_ROOT . "/front/dropdown.common.form.php");
+    } else {
+        Html::displayErrorAndDie(__('The requested dropdown does not exists', 'genericobject'));
+    }
 } else {
-
-   Html::displayErrorAndDie(__('Not Found!'));
+    Html::displayErrorAndDie(__('Not Found!'));
 }

front/commondropdown.php

@@ -28,19 +28,16 @@
  * -------------------------------------------------------------------------
  */
 
-include ("../../../inc/includes.php");
+include("../../../inc/includes.php");
 
 if (isset($_REQUEST['itemtype'])) {
-   $itemtype = $_REQUEST['itemtype'];
-   if (class_exists($itemtype)) {
-      $dropdown = new $itemtype();
-      include (GLPI_ROOT . "/front/dropdown.common.php");
-   } else {
-      Html::displayErrorAndDie(__('The requested dropdown does not exists', 'genericobject'));
-   }
+    $itemtype = $_REQUEST['itemtype'];
+    if (class_exists($itemtype)) {
+        $dropdown = new $itemtype();
+        include(GLPI_ROOT . "/front/dropdown.common.php");
+    } else {
+        Html::displayErrorAndDie(__('The requested dropdown does not exists', 'genericobject'));
+    }
 } else {
-
-   Html::displayErrorAndDie(__('Not Found!'));
+    Html::displayErrorAndDie(__('Not Found!'));
 }
-
-

front/commontreedropdown.form.php

@@ -28,17 +28,16 @@
  * -------------------------------------------------------------------------
  */
 
-include ("../../../inc/includes.php");
+include("../../../inc/includes.php");
 
 if (isset($_REQUEST['itemtype'])) {
-   $itemtype = $_REQUEST['itemtype'];
-   if (class_exists($itemtype)) {
-      $dropdown = new $itemtype();
-      include (GLPI_ROOT . "/front/dropdown.common.form.php");
-   } else {
-      Html::displayErrorAndDie(__('The requested dropdown does not exists', 'genericobject'));
-   }
+    $itemtype = $_REQUEST['itemtype'];
+    if (class_exists($itemtype)) {
+        $dropdown = new $itemtype();
+        include(GLPI_ROOT . "/front/dropdown.common.form.php");
+    } else {
+        Html::displayErrorAndDie(__('The requested dropdown does not exists', 'genericobject'));
+    }
 } else {
-
-   Html::displayErrorAndDie(__('Not Found!'));
+    Html::displayErrorAndDie(__('Not Found!'));
 }

front/commontreedropdown.php

@@ -28,5 +28,5 @@
  * -------------------------------------------------------------------------
  */
 
-include ("../../../inc/includes.php");
-include ("./commondropdown.php");
+include("../../../inc/includes.php");
+include("./commondropdown.php");