Add scm webhook delete mutation (#1331)

assets/src/generated/graphql.ts

@@ -4370,6 +4370,7 @@ export type RootMutationType = {
   deletePullRequest?: Maybe<PullRequest>;
   deleteRole?: Maybe<Role>;
   deleteScmConnection?: Maybe<ScmConnection>;
+  deleteScmWebhook?: Maybe<ScmWebhook>;
   deleteServiceContext?: Maybe<ServiceContext>;
   deleteServiceDeployment?: Maybe<ServiceDeployment>;
   deleteStack?: Maybe<InfrastructureStack>;
@@ -4849,6 +4850,11 @@ export type RootMutationTypeDeleteScmConnectionArgs = {
 };
 
 
+export type RootMutationTypeDeleteScmWebhookArgs = {
+  id: Scalars['ID']['input'];
+};
+
+
 export type RootMutationTypeDeleteServiceContextArgs = {
   id: Scalars['ID']['input'];
 };

lib/console/deployments/git.ex

@@ -207,7 +207,7 @@ defmodule Console.Deployments.Git do
   def create_scm_webhook(attrs, %User{} = user) do
     %ScmWebhook{}
     |> ScmWebhook.changeset(attrs)
-    |> allow(user, :edit)
+    |> allow(user, :write)
     |> when_ok(:insert)
   end
 
@@ -218,7 +218,7 @@ defmodule Console.Deployments.Git do
   def update_scm_webhook(attrs, id, %User{} = user) do
     get_scm_webhook!(id)
     |> ScmWebhook.changeset(attrs)
-    |> allow(user, :edit)
+    |> allow(user, :write)
     |> when_ok(:update)
   end
 
@@ -228,7 +228,7 @@ defmodule Console.Deployments.Git do
   @spec delete_scm_webhook(binary, User.t) :: webhook_resp
   def delete_scm_webhook(id, %User{} = user) do
     get_scm_webhook!(id)
-    |> allow(user, :edit)
+    |> allow(user, :write)
     |> when_ok(:delete)
   end
 

lib/console/graphql/deployments/git.ex

@@ -582,6 +582,13 @@ defmodule Console.GraphQl.Deployments.Git do
       safe_resolve &Deployments.create_webhook_for_connection/2
     end
 
+    field :delete_scm_webhook, :scm_webhook do
+      middleware Authenticated
+      arg :id, non_null(:id)
+
+      safe_resolve &Deployments.delete_scm_webhook/2
+    end
+
     @desc "creates a webhook reference in our system but doesn't attempt to create it in your upstream provider"
     field :create_scm_webhook_pointer, :scm_webhook do
       middleware Authenticated

lib/console/graphql/resolvers/deployments/git.ex

@@ -115,6 +115,9 @@ defmodule Console.GraphQl.Resolvers.Deployments.Git do
   def create_webhook(%{attributes: attrs}, %{context: %{current_user: user}}),
     do: Git.create_webhook(attrs, user)
 
+  def delete_scm_webhook(%{id: id}, %{context: %{current_user: user}}),
+    do: Git.delete_scm_webhook(id, user)
+
   def setup_renovate(%{connection_id: id, repos: repos} = args, %{context: %{current_user: user}}),
     do: Git.setup_renovate(args, id, repos, user)
 

schema/schema.graphql

@@ -523,6 +523,8 @@ type RootMutationType {
 
   createScmWebhook(connectionId: ID!, owner: String!): ScmWebhook
 
+  deleteScmWebhook(id: ID!): ScmWebhook
+
   "creates a webhook reference in our system but doesn't attempt to create it in your upstream provider"
   createScmWebhookPointer(attributes: ScmWebhookAttributes!): ScmWebhook
 

test/console/graphql/mutations/deployments/git_mutations_test.exs

@@ -313,4 +313,34 @@ defmodule Console.GraphQl.Deployments.GitMutationsTest do
       }, %{current_user: insert(:user)})
     end
   end
+
+  describe "deleteScmWebhook" do
+    test "admins can delete scm webhooks" do
+      admin = admin_user()
+      hook = insert(:scm_webhook)
+
+      {:ok, %{data: %{"deleteScmWebhook" => deleted}}} = run_query("""
+        mutation Delete($id: ID!) {
+          deleteScmWebhook(id: $id) {
+            id
+          }
+        }
+      """, %{"id" => hook.id}, %{current_user: admin})
+
+      assert deleted["id"] == hook.id
+      refute refetch(hook)
+    end
+
+    test "non-admins cannot delete" do
+      hook = insert(:scm_webhook)
+
+      {:ok, %{errors: [_ | _]}} = run_query("""
+        mutation Delete($id: ID!) {
+          deleteScmWebhook(id: $id) {
+            id
+          }
+        }
+      """, %{"id" => hook.id}, %{current_user: insert(:user)})
+    end
+  end
 end