Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update aws efs scraper #1688

Merged
merged 3 commits into from
Dec 17, 2024
Merged

update aws efs scraper #1688

merged 3 commits into from
Dec 17, 2024

Conversation

seemywingz
Copy link
Contributor

Test Plan

manually tested the changes locally and verified the scraper has the desired output

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@linear Linear
Copy link

linear bot commented Dec 16, 2024

PROD-3010 efs csi driver scraper seems broken

michaeljguarino
michaeljguarino approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, but i feel like there might be a way to just have this take the last known efs driver version as the first in the list always. Snce the intermediate versions aren't actually that helpful.

@seemywingz seemywingz added the enhancement New feature or request label Dec 17, 2024
@seemywingz seemywingz merged commit b1e50d6 into master Dec 17, 2024
8 checks passed
@seemywingz seemywingz deleted the PROD-3010/efs-csi-driver-scraper branch December 17, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seemywingz @michaeljguarino