feat: add configurationRef to GeneratedSecret #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zreigz
changed the title
zreigz
added
enhancement
michaeljguarino
approved these changes
Dec 17, 2024
michaeljguarino
requested changes
Dec 17, 2024
| data[k] = value | ||
| } | ||
| } | ||
| data = lo.Assign(data, generatedSecret.Spec.Template) |
There was a problem hiding this comment.
Oh wait no, the secret should be passed to the liquid template engine as a map like {"configuration": data} instead of just merging the secrets. That way we can write more advanced logic on top.
|
@michaeljguarino PTAL |
michaeljguarino
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend GeneratedSecret with configurationRef. The
configurationRefpoints to another secret, allowing us to take the output of one GeneratedSecret and use it for templating another.Test Plan
Checklist