feat!: Light mode #514
Merged
feat!: Light mode #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly label Inputs within FormFields - Remove excess margins around FormFields that don’t have top or bottom content.
Still need to change text color
But note that I think we should change it
Yet more sane severity handling
|
Visit the preview URL for this PR (updated for commit 5df127a): https://pluralsh-design--pr514-klink-light-mode-kes06fdd.web.app (expires Fri, 29 Sep 2023 19:15:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 784914c934330f8d0a9fd65c68898b3988262b7d |
dogmar
force-pushed
the
klink/light-mode
branch
from
f0c19c3 to
7546804
Compare
Still need to add variants for console and app
michaeljguarino
approved these changes
Sep 25, 2023
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add light-mode color support as well as various fixes/improvements to design system components.