Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormField label margin too large, button reset #521

Merged
merged 3 commits into from
Oct 13, 2023
Merged

fix: FormField label margin too large, button reset #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa0bb22
Fix FormField label margin
dogmar Oct 3, 2023
ae3347e
More refinements to button reset
dogmar Oct 3, 2023
7d40671
Merge branch 'main' into klink/formfield-margins
dogmar Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/FormField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ function FormFieldRef(
fontWeight="600"
flexShrink={0}
flexGrow={1}
margin={0}
{...labelProps}
>
{label}
Expand Down
3 changes: 3 additions & 0 deletions src/stories/FormField.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,15 @@ export const Caption = AllSizesTemplate.bind({})

Caption.args = {
label: 'Password',
caption: 'A short caption',
}

export const LongCaption = AllSizesTemplate.bind({})

LongCaption.args = {
label: 'Label',
caption:
'This will probably truncate, because it is ever so so longer than usual.',
}

export const HintText = AllSizesTemplate.bind({})
Expand Down
3 changes: 2 additions & 1 deletion src/theme/resets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ export const resetPartials = {
padding: 0,
font: 'inherit',
cursor: 'pointer',
outline: 'inherit',
outline: 'unset',
alignItems: 'unset',
appearance: 'none',
},
list: {
margin: 0,
Expand Down
Loading