add kubecon landing page #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plural-marketing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jsladerman
force-pushed
the
jake/prod-2765-implement-kubecon-landing-page
branch
from
b5a3e07 to
5bf8615
Compare
jsladerman
force-pushed
the
jake/prod-2765-implement-kubecon-landing-page
branch
3 times, most recently
from
57f1c31 to
967332a
Compare
pages/_document.tsx
Outdated
| @@ -41,6 +41,17 @@ class MyDocument extends Document { | |||
| rel="stylesheet" | |||
| href="https://cdn.jsdelivr.net/npm/@docsearch/css@3" | |||
| /> | |||
| {/* <!-- Google Tag Manager --> */} | |||
| <script | |||
| dangerouslySetInnerHTML={{ | |||
There was a problem hiding this comment.
is this how it's supposed to be done?
jsladerman
force-pushed
the
jake/prod-2765-implement-kubecon-landing-page
branch
from
967332a to
f28aabc
Compare
michaeljguarino
approved these changes
Oct 24, 2024
| </Head> | ||
| <body> | ||
| {/* <!-- Google Tag Manager (noscript) --> */} | ||
| <noscript> |
There was a problem hiding this comment.
that's not in the google tag manager thing too?
There was a problem hiding this comment.
it's for cases of user having JS disabled
There was a problem hiding this comment.
wasn't clear from the docs, and i figure it doesn't hurt to leave it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adds new google analytics scripts
closes prod-2792, prod-2793