Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update DS to 3.72.1 #123

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

jsladerman
Copy link
Contributor

@jsladerman jsladerman commented Nov 22, 2024

updates DS to 3.72.1, which seems to be about the last version (just before pluralsh/design-system#650 where we did a handful of major dependency updates) that doesn't break things related to SSR. but this now lets us use most of the icons currently in the DS

Summary by CodeRabbit

Release Notes

  • New Features

    • Updated dependencies to enhance performance and compatibility.
    • Improved the BareModal component for better accessibility and dynamic rendering.
    • Streamlined navigation handling in the NavigationMobile component.
  • Bug Fixes

    • Replaced a button in the BareModal to ensure consistent functionality.
  • Chores

    • Removed unused components and icons to clean up the codebase.

@jsladerman jsladerman added the enhancement New feature or request label Nov 22, 2024
@jsladerman jsladerman requested a review from a team as a code owner November 22, 2024 00:00
Copy link

linear bot commented Nov 22, 2024

Copy link

coderabbitai bot commented Nov 22, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces several updates across multiple files, primarily focusing on dependency version changes in package.json and modifications to various components. Key changes include updating libraries to newer versions, restructuring the BareModal component to enhance accessibility and streamline its implementation, and replacing the Accordion component with AccordionItem in the NavigationMobile component. Additionally, the StackRunIcon was removed from the MultiColumnText component, and an unused styled component template file was deleted.

Changes

File Change Summary
package.json Updated dependencies: @pluralsh/design-system to 3.72.1, react to 18.3.1, react-dom to 18.3.1, react-is to 18.3.1, @types/react-dom to 18.3.0, and @graphql-codegen/cli to 5.0.0.
pages/index.tsx Removed and re-added a Button component within BareModal. No changes to logic or functionality.
src/components/BareModal.tsx Transitioned to a functional component using DynamicModalWrapper, updated props, simplified lifecycle handling, and enhanced accessibility with VisuallyHidden.
src/components/NavigationMobile.tsx Replaced Accordion with AccordionItem, updated navigation rendering logic, and adjusted styling.
src/components/_ComponentTemplate.tsx Deleted file containing unused styled component templates.
src/components/custom-page/MultiColumnText.tsx Removed createIcon import and StackRunIcon definition from the icons object.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NavigationMobile
    participant AccordionItem
    participant MobileMainLink

    User->>NavigationMobile: Clicks on navigation item
    NavigationMobile->>AccordionItem: Opens sub-navigation
    AccordionItem->>MobileMainLink: Displays sub-navigation links
Loading

🐰 "In the garden of code, we hop and play,
With buttons and icons, we brighten the day.
Dependencies updated, our paths now align,
In the world of React, everything's fine!
So let’s dance through the changes, with joy and delight,
A rabbit's cheer for code, oh what a sight!" 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint (1.23.1)

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning @pluralsh/eslint-config-typescript > [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning @pluralsh/eslint-config-typescript > @pluralsh/eslint-config-pluralsh > [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning @pluralsh/eslint-config-typescript > eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning @pluralsh/eslint-config-typescript > eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning @pluralsh/design-system > @floating-ui/[email protected]: Package renamed to @floating-ui/react
warning @graphql-codegen/introspection > @graphql-codegen/visitor-plugin-common > @graphql-tools/relay-operation-optimizer > @ardatan/relay-compiler > [email protected]: Glob versions prior to v9 are no longer supported
warning @graphql-codegen/introspection > @graphql-codegen/visitor-plugin-common > @graphql-tools/relay-operation-optimizer > @ardatan/relay-compiler > babel-preset-fbjs > @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
warning @graphql-codegen/introspection > @graphql-codegen/visitor-plugin-common > @graphql-tools/relay-operation-optimizer > @ardatan/relay-compiler > babel-preset-fbjs > @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
error @pluralsh/[email protected]: The engine "node" is incompatible with this module. Expected version "18.19.1". Got "22.9.0"
error Found incompatible module.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for plural-marketing ready!

Name Link
🔨 Latest commit 4ab9a05
🔍 Latest deploy log https://app.netlify.com/sites/plural-marketing/deploys/673fc987c77dfe0008fb1a39
😎 Deploy Preview https://deploy-preview-123--plural-marketing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jsladerman jsladerman merged commit 42820db into main Nov 22, 2024
8 of 10 checks passed
@jsladerman jsladerman deleted the jake/prod-2907-update-ds-in-marketing-website branch November 22, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants