fix(capi-cluster): add labels and annotations to machinepool #849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes that the labels and annotations weren't being set on the
MachinePool
object. This meant that autoscaling wasn't working, since the annotation to specify an external autoscaler is being used needs to be on theMachinePool
resource.Test Plan
Add new unit tests that ensures the labels and annotations from the AWS and GCP node pool defaults and node pool overrides are propagated onto the GCP and AWS managed machine pool and
MachinePool
resources.Checklist
plural from-grafana
to convert a grafana dashboard found via google to our CRDpluralsh/module-library
to accelerate this