Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(capi-cluster): add labels and annotations to machinepool #849

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

davidspek
Copy link
Contributor

Summary

This PR fixes that the labels and annotations weren't being set on the MachinePool object. This meant that autoscaling wasn't working, since the annotation to specify an external autoscaler is being used needs to be on the MachinePool resource.

Test Plan

Add new unit tests that ensures the labels and annotations from the AWS and GCP node pool defaults and node pool overrides are propagated onto the GCP and AWS managed machine pool and MachinePool resources.

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@davidspek davidspek added the bug Something isn't working label Sep 13, 2023
@davidspek davidspek merged commit c504d31 into main Sep 14, 2023
5 of 6 checks passed
@davidspek davidspek deleted the fix-capi-autoscaling branch September 14, 2023 08:01
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@davidspek davidspek restored the fix-capi-autoscaling branch December 19, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants