Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bootstrap): add knobs to set control plane network setup and encryption config #859

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat(bootstrap): add knobs to set control plane network setup and encryption config #859

merged 1 commit into from
Oct 5, 2023

Conversation

michaeljguarino
Copy link
Member

Summary

Also bumps aws-load-balancer controller to most recent version

Test Plan

link, confirmed terraform plan was empty

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@michaeljguarino michaeljguarino added the enhancement New feature or request label Oct 4, 2023
@michaeljguarino
Add knobs to set control plane network setup and encryption config
2957380 
Also bumps aws-load-balancer controller to most recent version
davidspek
davidspek approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidspek davidspek changed the title Add knobs to set control plane network setup and encryption config feat(bootstrap): add knobs to set control plane network setup and encryption config Oct 5, 2023
@davidspek davidspek merged commit 046b877 into main Oct 5, 2023
4 of 6 checks passed
@davidspek davidspek deleted the security-knobs branch October 5, 2023 15:03
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidspek davidspek davidspek approved these changes

@rauerhans rauerhans Awaiting requested review from rauerhans

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeljguarino @plural-bot @davidspek