Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade ray -> 2.7 #863

Merged
merged 11 commits into from
Oct 10, 2023
Merged

Conversation

troyyyang
Copy link
Contributor

Summary

was testing #713 which upgrades to 2.5. for some reason the head node was constantly restarting. i pulled the branch in my fork and bumped it to 2.7 and tested in an aws cluster. head node is stable, and ran some cursory tests that all worked.

Test Plan

tested on aws cluster
image

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@troyyyang troyyyang marked this pull request as draft October 6, 2023 15:12
@troyyyang
Copy link
Contributor Author

troyyyang commented Oct 6, 2023

Potential issues after more stringent testing

resolved

@troyyyang troyyyang marked this pull request as ready for review October 6, 2023 23:10
@troyyyang troyyyang marked this pull request as draft October 7, 2023 01:33
@@ -3,8 +3,8 @@ name: kuberay-operator
description: A Helm chart for Kubernetes
type: application
version: 0.1.3
appVersion: "v0.3.0"
appVersion: "v0.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appVersion here should be v2.7.0 (the version of ray itself)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in ray/helm/ray/Chart.yaml i have the appVersion set to 2.7.0. since this chart.yaml is for kuberay i put the kuberay operator version, i can switch this to 2.7.0 but just want to double check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i didn't realize, that's probably fine.

@@ -3,8 +3,8 @@ name: kuberay-operator
description: A Helm chart for Kubernetes
type: application
version: 0.1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to bump this as well

@michaeljguarino
Copy link
Member

hey @troyyyang is there a reason this is still a draft PR? Let us know when it's ready to test on our end and we can get it merged.

@troyyyang troyyyang marked this pull request as ready for review October 9, 2023 20:01
@troyyyang
Copy link
Contributor Author

hey @troyyyang is there a reason this is still a draft PR? Let us know when it's ready to test on our end and we can get it merged.

let me know what i should do with the appversion, but otherwise all set

ray/helm/ray/Chart.yaml Outdated Show resolved Hide resolved
@@ -3,8 +3,8 @@ name: kuberay-operator
description: A Helm chart for Kubernetes
type: application
version: 0.1.3
appVersion: "v0.3.0"
appVersion: "v0.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i didn't realize, that's probably fine.

@michaeljguarino michaeljguarino merged commit 4bb87b2 into pluralsh:main Oct 10, 2023
4 of 6 checks passed
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants