Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gcp): let helm manage certmanager SA instead of terraform #882

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

floreks
Copy link
Member

@floreks floreks commented Nov 10, 2023

Summary

It relies on terraform being executed first and removing certmanager SA. Then helm will recreate it with proper annotation and cert-manager deployment should get restarted thanks to new checksum/sa annotation.

Test Plan

Locally with link

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@floreks floreks added the enhancement New feature or request label Nov 10, 2023
@floreks floreks self-assigned this Nov 10, 2023
@floreks floreks merged commit c6558ef into main Nov 10, 2023
4 of 5 checks passed
@floreks floreks deleted the update/gcp-bootstrap branch November 10, 2023 15:49
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants