feat(gcp): let helm manage certmanager SA instead of terraform #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It relies on terraform being executed first and removing
certmanager
SA. Then helm will recreate it with proper annotation and cert-manager deployment should get restarted thanks to newchecksum/sa
annotation.Test Plan
Locally with link
Checklist
plural from-grafana
to convert a grafana dashboard found via google to our CRDpluralsh/module-library
to accelerate this