Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: airbyte hooks #921

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: airbyte hooks #921

merged 1 commit into from
Oct 10, 2024

Conversation

michaeljguarino
Copy link
Member

Apparently the forked chart still had hooks for the service account (to support adding the bootloader as a hook). This has likely been the root cause of a lot of dumb bugs with service account access tokens, and ditching it is a good idea.

Test Plan

n/a

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@michaeljguarino michaeljguarino added the enhancement New feature or request label Oct 10, 2024
@michaeljguarino michaeljguarino requested a review from a team October 10, 2024 17:19
Apparently the forked chart still had hooks for the service account (to support adding the bootloader as a hook).  This has likely been the root cause of a lot of dumb bugs with service account access tokens, and ditching it is a good idea.
@michaeljguarino michaeljguarino changed the title Fix airbyte hooks fix: airbyte hooks Oct 10, 2024
@michaeljguarino michaeljguarino merged commit 4b46a3d into main Oct 10, 2024
7 of 9 checks passed
@michaeljguarino michaeljguarino deleted the fix-airbyte-hooks branch October 10, 2024 17:22
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants