Autogenerate basic helm readme's for app umbrella charts #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help at least provide some usable documentation for how to reconfigure helm charts
michaeljguarino
force-pushed
the
helm-docs
branch
from
1b69cd2 to
79438bd
Compare
zreigz
reviewed
Sep 15, 2023
| Usage: "output to stdout instead of to a file", | ||
| }, | ||
| }, | ||
| Action: latestVersion(func(c *cli.Context) error { return appReadme(c.Args().Get(0), c.Bool("dry-run")) }), |
There was a problem hiding this comment.
would be good to add requireArgs helper
zreigz
approved these changes
Sep 15, 2023
michaeljguarino
added a commit
that referenced
this pull request
Aug 28, 2024
* Autogenerate basic helm readme's for app umbrella charts This will help at least provide some usable documentation for how to reconfigure helm charts * bump helm-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will help at least provide some usable documentation for how to reconfigure helm charts
Test Plan
local tested on a few charts, also swallows errors to avoid blocking
plural buildChecklist