Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent install command broke when auth-less #505

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

michaeljguarino
Copy link
Member

You can technically run plural cd install w/o authenticating to the console, but the new global settings fetch breaks that. Make that code a bit more defensive

Summary

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added bug-fix This pull request fixes a bug hotfix labels Apr 20, 2024
You can technically run `plural cd install` w/o authenticating to the console, but the new global settings fetch breaks that.  Make that code a bit more defensive
@michaeljguarino michaeljguarino force-pushed the fix-broken-agent-install branch from 895f62d to c9f60b2 Compare April 21, 2024 03:25
@michaeljguarino michaeljguarino merged commit 836c4ae into main Apr 21, 2024
14 of 15 checks passed
@michaeljguarino michaeljguarino deleted the fix-broken-agent-install branch April 21, 2024 04:45
michaeljguarino added a commit that referenced this pull request Aug 28, 2024
You can technically run `plural cd install` w/o authenticating to the console, but the new global settings fetch breaks that.  Make that code a bit more defensive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant