check if deployment operator already exists #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zreigz
requested review from
michaeljguarino,
floreks and
maciaszczykm
as code owners
michaeljguarino
approved these changes
May 18, 2024
| @@ -117,6 +117,15 @@ func (p *Plural) doInstallOperator(url, token, values string) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| alreadyExists, err := console.IsAlreadyAgentInstalled(p.Kube.GetClient()) | |||
There was a problem hiding this comment.
we potentially should add an argument here to not do this check on plural cd clusters reinstall (the expectation is you are updating an already existing agent)
michaeljguarino
pushed a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
check if deployment operator already exists and confirm if so
Labels
Test Plan
Checklist