feat: add support for glob pattern to the prautomation->deletes->files #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floreks
requested review from
michaeljguarino,
zreigz and
maciaszczykm
as code owners
| @@ -40,3 +40,18 @@ func replaceTo(from, to string, rep func(data []byte) ([]byte, error)) error { | |||
| func replaceInPlace(path string, rep func(data []byte) ([]byte, error)) error { | |||
| return replaceTo(path, path, rep) | |||
| } | |||
|
|
|||
| func removeMatches(glob string) error { | |||
| matches, err := filepath.Glob(glob) | |||
There was a problem hiding this comment.
does this still work for non-glob patterns?
There was a problem hiding this comment.
yep, if full filepath is provided, filepath.Glob checks for file existence and returns it as part of matches array if it exists, otherwise it returns null and nothing happens.
michaeljguarino
approved these changes
Dec 18, 2024
michaeljguarino
deleted the
sebastian/prod-3014-support-file-globs-in-deletes-for-plural-template-pr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref: PROD-3014
Test Plan
Locally with some basic glob patterns and direct paths, i.e.:
Checklist