-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAPT-1435: Add replacementTopics & previousTopics fields to track lineage of a deprecated topic #861
Open
aman-minz
wants to merge
15
commits into
master
Choose a base branch
from
ADAPT-1435
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-minz
changed the title
WIP-ADAPT-1435: Add place holders for replacementTopic & previousTopics
ADAPT-1435: Add place holders for replacementTopic & previousTopics
Jul 20, 2023
Revert rbac and Mykola's tests (temporary)
Revert BACK rbac and Mykola's tests
) * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Fixing unit test cases - From Aman & Abhishek * Fix compilation issue and update tests * Add more tests * Add more tests * Remove unused import * Revert TopicDeletionProgramSpec as the methods call across modules fails * ADAPT-1566: add retries for getVersion and getAllVersions from schema… (#849) * ADAPT-1566: add retries for getVersion and getAllVersions from schema registry * ADAPT-1148: added msk rbac (#845) * ADAPT-1148: added msk rbac * ADAPT-1148: make msk arn env var as optional (#850) * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Fixing unit test cases - From Aman & Abhishek * Add more tests * Incorporate review comments * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Add more tests * Add test for InstantUtils and refactor * ADAPT-1570 Need a mechanism to validate logical types (#851) * ADAPT-1570 Need a mechanism to validate logical types * ADAPT-1570 Need a mechanism to validate logical types *added tests for comosite keys --------- Co-authored-by: Mykola Nikulesko <[email protected]> * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Add test for InstantUtils and refactor * Incorporate review comments * Refactored and removed unwanted variables and methods * Store default loophole cutoff date in a variable * Fix failing unit test * Remove InstantUtils.scala * Update default loophole cut-off date --------- Co-authored-by: Abhishek <[email protected]> Co-authored-by: Iryna Biletska <[email protected]> Co-authored-by: mnikulesko <[email protected]> Co-authored-by: Mykola Nikulesko <[email protected]>
aman-minz
changed the title
ADAPT-1435: Add place holders for replacementTopic & previousTopics
ADAPT-1435: Add replacementTopics & previousTopics fields to track lineage of deprecated topic
Aug 3, 2023
aman-minz
changed the title
ADAPT-1435: Add replacementTopics & previousTopics fields to track lineage of deprecated topic
ADAPT-1435: Add replacementTopics & previousTopics fields to track lineage of a deprecated topic
Aug 8, 2023
aman-minz
requested review from
RenjithSomasekharan,
abhivermaaa,
shreedhar-kc,
znickle24,
irynabiletskaps and
mnikulesko
August 11, 2023 10:36
… patterns in new fields always
shreedhar-kc
approved these changes
Aug 31, 2023
Is this still planned? |
Yes, @olivierlacan. However, we have few other PRs which needs to go before this. We will update you as soon as this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for ADAPT-1435 introduces new fields as below to track the lineage of a topic being deprecated.
NOTE: The metadata fields
replacementTopics
&previousTopics
should be populated by the producers of a topic.replacementTopics:
replacementTopics
field in metadata was conceived.replacementTopics
field must be set whenever the current topic is deprecated.previousTopics:
replacementTopics
, one could trace the lineage from old-to-new.previousTopics
was conceived.additionalValidations:
additionalValidations
is introduced to get rid of cutoff-date.additionalValidations
. Therefore, no new additional validations will be applied on them.replacementTopics
. Thus, corresponding field will be validated.additionalValidations
field of only the new topics will be updated with alladditionalValidations
including new enums. Thus, new additional validations will be applied henceforth.