Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#138 Add initial CMake support #161

Closed
wants to merge 1 commit into from

Conversation

YarikTH
Copy link
Contributor

@YarikTH YarikTH commented Aug 7, 2021

CMake is checked to work as a cmake subdirectory and as an installed cmake package.

See usage example at https://github.com/YarikTH/v8pp_cmake_integration_test

@YarikTH YarikTH force-pushed the isssue/#138-CMake_support branch 2 times, most recently from 2f7d5c9 to d9784e6 Compare August 7, 2021 20:28
@pmed
Copy link
Owner

pmed commented Aug 8, 2021

Hi,

thank you for the work! I also have an unpublished branch for CMake support, where v8pp/config.hpp is generated from a list of CMakeList.txt options. I will look how to combine it with you approach.

@YarikTH
Copy link
Contributor Author

YarikTH commented Aug 8, 2021

Points to improve:

  • Move Config.cmake.in and FindV8.cmake into cmake or support/cmake folder
  • Add CMakeLists.txt to plugins and add ctest target equivalent to "./v8pp_test -v --run-tests test/console.js test/file.js"
  • See at https://github.com/friendlyanon/cmake-init for more ideas, especially at the usage of CMakePresets.json
    • By the way, they had template for vcpkg support that was requested some time ago Support Vcpkg #128

@YarikTH YarikTH force-pushed the isssue/#138-CMake_support branch from d9784e6 to 44ffb9f Compare September 5, 2021 11:21
@YarikTH YarikTH closed this Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants