New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first ugly support for std::function overload for v8pp::convert #169

Closed

YarikTH wants to merge 1 commit into pmed:master from YarikTH:isssue/#142-support_function_parameter

Contributor

YarikTH commented Aug 10, 2021 •

edited

Loading

Need to add tests
Fix forward declaration of wrap_function (Template parameter redefines default argument in "typename Traits = raw_ptr_traits")
Make sure function converter is composable with other converters (std::function<void(std::vector)>, std::vector<std::function<void()>> etc)
Fix problem that caller should additionally include v8pp/call_v8.hpp or template call_v8 would be illformed

Closes #142


          Add first ugly support for std::function overload for v8pp::convert

5dc8615

YarikTH closed this

pmed mentioned this pull request

Support std::function as function parameter #142

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet