Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle ObjectTemplate::SetAccessor API change in v8 12.1 #204

Merged
merged 1 commit into from
Jan 2, 2024
Merged

handle ObjectTemplate::SetAccessor API change in v8 12.1 #204

merged 1 commit into from
Jan 2, 2024

Conversation

jcmonnin
Copy link
Contributor

@jcmonnin jcmonnin commented Jan 2, 2024

pmed
pmed approved these changes Jan 2, 2024
View reviewed changes
Copy link
Owner

@pmed pmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jcmonnin

perfect, thanks a lot!

@pmed pmed merged commit dcbbfad into pmed:master Jan 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmed pmed pmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcmonnin @pmed