Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Move to file code action #224

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

pmizio
Copy link
Owner

@pmizio pmizio commented Jan 17, 2024

TODO:

  • config option to pass other telescope builtin pickers (default find_files)
  • config option to pass custom function as file picker(allow to use other things than telescope)

@pmizio pmizio linked an issue Jan 17, 2024 that may be closed by this pull request
@mmirus
Copy link

mmirus commented Mar 8, 2024

Hello! Is there any plan to merge this? I'm happy to help test if that would be useful.

@foodornt
Copy link

Yes please! I had fun using this in VSCode

@unphased
Copy link

unphased commented Aug 8, 2024

It works great! there is just one issue where if the target file does not have a newline at the end (or i guess, technically speaking, that would be, two newlines at the end), stuff you're moving doesnt land in there. That's the main big bug i found over the past couple months daily driving this (i use it in bursts once every few weeks).

@KostkaBrukowa
Copy link
Collaborator

@unphased I've might have fixed this problem. Can you check if the fix works for you?

@kloczewiak
Copy link

Any update? Can we get this merged?

@unphased
Copy link

I think we should go ahead with this. I tried to look up the vim.lsp.util.apply_workspace_edit API but I can't find any more information about what a WorkspaceEdit is...

@marcesengel
Copy link

Would love to get this as well, thanks! 😍 Until then I'll just point to this branch and report back if there are any issues 🙌

@KostkaBrukowa KostkaBrukowa marked this pull request as ready for review November 20, 2024 10:34
@KostkaBrukowa KostkaBrukowa merged commit 346062e into master Nov 21, 2024
19 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Move to file" code action
7 participants