fix: completeFunctionCalls adds brackets when writing JSX #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-gail
changed the title
m-gail
changed the title
|
Hi, thanks for your contribution. I'm still on my vacation so I'll test it next week! |
m-gail
commented
Feb 26, 2024
| @@ -137,6 +137,12 @@ end | |||
| function M.handler(request, response, params) | |||
| local requested_bufnr = vim.uri_to_bufnr(vim.uri_from_fname(params.data.file)) | |||
| local filetype = vim.bo[requested_bufnr].filetype | |||
| local is_valid_context_for_function_snippet = utils.is_valid_context_for_function_snippet( | |||
| requested_bufnr, | |||
| params.data, | |||
There was a problem hiding this comment.
After using this PR for a bit, I've noticed that the position here does under some circumstances not get updated between when it first appears as a completion item and when it is chosen as a completion.
For example, when you are in insert mode and press backspace, the results and positions remain the same, which can lead to some unexpected behavior like this (| indicates cursor position):
# go into insert mode
{fooBarBaz|}<Component></Component>
# press backspace once, if you complete now, a snippet is used correctly
{fooBarBa|}<Component></Component>
# press backspace two more times, if you complete now, a snippet is not used
# even though it should be
# because the position is still the same as in step 1, but there is a '<'
# on that position now
{fooBar|}<Component></Component>
The problem could be solved, by querying the current cursor position from nvim here, instead of using the params, but I'm not sure if there is a better solution to this.
Closed
|
Any updates on this? |
|
This would be a really nice improvement. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #239
Fixes brackets being placed wrongly (for example with JSX and import statements) when complete_function_calls is set to true as described in the linked issue.
Old behavior
New behavior