Skip to content

Commit

Permalink
Revert "BinaryStream: add PHPStan type hint for get() parameter"
Browse files Browse the repository at this point in the history
This reverts commit 22ac3f1.

This doc comment turned out to be very inconvenient and would require
propagating signed/unsigned types everywhere. Considering we're in the
process of phasing out this library anyway, it doesn't make much sense
to introduce this inconvenience everywhere.
  • Loading branch information
dktapps committed Mar 4, 2024
1 parent 9964db0 commit ccfc189
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/BinaryStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ public function getBuffer() : string{
/**
* @phpstan-impure
* @throws BinaryDataException if there are not enough bytes left in the buffer
*
* @phpstan-param int<0, max> $len
*/
public function get(int $len) : string{
if($len === 0){
Expand Down

0 comments on commit ccfc189

Please sign in to comment.