yaml-ify map metadata & iQue pm_map #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! I'll wait for another review or two though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces hardcoded offsets and sizes for each version in the script for this reason.
In the continuation of the tasks listed on #1126 this also resolves by dumping the raw compressed title data section from the baserom, then at the map segment building step we first write the mentioned raw dump to make out with the unusable data at the end, then overwrite in place with our newly formed title data using the new size as the result. It's likely possible to get rid of this dump method entirely in which we could find out how to manage those unused garbage data at the end.
and yeah be wary that the file
sbk_bg.alt.pnghas been renamed tosbk_bg.1.png. lmk what any other suggestions or changes I've missed on or if any sections of this wasn't in ur taste just tell me.