Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for colons in node names when parsing reference keys #8

Merged
merged 1 commit into from
May 17, 2024
Merged

Add support for colons in node names when parsing reference keys #8

merged 1 commit into from
May 17, 2024

Conversation

knoxsp
Copy link
Collaborator

@knoxsp knoxsp commented May 17, 2024

No description provided.

@knoxsp knoxsp requested a review from pmslavin May 17, 2024 13:08
pmslavin
pmslavin approved these changes May 17, 2024
View reviewed changes
Copy link
Owner

@pmslavin pmslavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and current models are using names containing colons so this support is required.

@pmslavin pmslavin merged commit 0d016dd into master May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmslavin pmslavin pmslavin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knoxsp @pmslavin