Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image picker enhancements #1367

Closed
Moataz-Vodafone opened this issue Nov 18, 2022 · 5 comments · Fixed by #1912
Closed

Image picker enhancements #1367

Moataz-Vodafone opened this issue Nov 18, 2022 · 5 comments · Fixed by #1912
Assignees
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@Moataz-Vodafone
Copy link

Site menu interface should match the way the OneDrive section displays folders. When you select the OneDrive section, folders are displayed using the yellow folder icon, but when you select the Site section, only a grey box is displayed.

Upload doesn't prompt with browser file picker when selected. When you click on Upload using the OOTB image picker, it displays a file picker without the user having to click the Choose file link first.
From a link needs the instruction text updating, and doesn't have any placeholder text. OOTB there is "https://" as placeholder text, and different instructions are provided.

Selected text doesn't match site theme colour (our theme in the example screenshots uses red):

@ghost
Copy link

ghost commented Nov 18, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 18, 2022
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@michaelmaillot
Copy link
Collaborator

Hi @Moataz-Vodafone,

Sounds like interesting improvment ideas!

FYI regarding the selected text which doesn't match theme colour, this has been fixed with latest version:

image

@michaelmaillot michaelmaillot added help wanted type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Sep 11, 2023
@Ateina
Copy link
Contributor

Ateina commented Apr 7, 2024

Hi @michaelmaillot
I want to contribute to this issue. Could you please assign it me?

@michaelmaillot michaelmaillot added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed help wanted labels Apr 8, 2024
@michaelmaillot
Copy link
Collaborator

It's all yours 🙂

Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue Apr 9, 2024
Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue Apr 9, 2024
Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue Apr 9, 2024
Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue Apr 9, 2024
Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue Oct 15, 2024
@michaelmaillot michaelmaillot added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Nov 26, 2024
@michaelmaillot michaelmaillot added this to the 3.20.0 milestone Nov 26, 2024
@AJIXuMuK AJIXuMuK mentioned this issue Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants