Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1367: Image picker enhancements #1805

Merged
merged 10 commits into from
Nov 26, 2024

Conversation

Ateina
Copy link
Contributor

@Ateina Ateina commented Apr 9, 2024

Q A
Bug fix? [X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1367

What's in this Pull Request?

PR contains changes to the FilePicker control to match OOTB Sharepoint File Picker

  • Added placeholder to the 'From a link' tab

image

  • Updated layout for 'Site' tab

Before:
image

PR:
7

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the first contribution to this project.

Ateina and others added 2 commits May 21, 2024 22:50
# Conflicts:
#	src/controls/filePicker/LinkFilePickerTab/LinkFilePickerTab.tsx
Copy link
Collaborator

@michaelmaillot michaelmaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Ateina!

I've added few things to update. Let me know if something's not right from your side 🙂

@Ateina
Copy link
Contributor Author

Ateina commented Aug 19, 2024

@michaelmaillot Thank you for review, I'm working on update for more responsive layout :)

@michaelmaillot michaelmaillot merged commit 2fa480c into pnp:dev Nov 26, 2024
1 check passed
@michaelmaillot
Copy link
Collaborator

Merged manually, thank you!

@michaelmaillot michaelmaillot added this to the 3.20.0 milestone Nov 26, 2024
michaelmaillot added a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants