Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plot rounds respect levels #300

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JanEricNitschke
Copy link
Collaborator

Previously plot rounds showed the two levels for maps that have them but only plotted the player and bomb in the upper half. Now it should also plot them in the lower one if they are there.

@pnxenopoulos pnxenopoulos marked this pull request as ready for review October 21, 2023 14:26
pnxenopoulos
pnxenopoulos previously approved these changes Oct 21, 2023
Copy link
Owner

@pnxenopoulos pnxenopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. i think this addresses the question in Discord

@JanEricNitschke
Copy link
Collaborator Author

I would still like to figure out why the levels half the width instead of doubling the height.

@pnxenopoulos
Copy link
Owner

I would still like to figure out why the levels half the width instead of doubling the height.

All good, in no rush to merge

@JanEricNitschke
Copy link
Collaborator Author

Shoud be all good now. But note that there are breaking changes in here to plot_positions.

@pnxenopoulos
Copy link
Owner

Currently adding this in v2. Will be referencing. I found in the data the z-level cutoffs fortunately.

@pnxenopoulos pnxenopoulos added the Feature Request Issues related to feature requests label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Issues related to feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants