Skip to content

Commit

Permalink
enh(NumberFormatter): Introduce backward compatible options for forma…
Browse files Browse the repository at this point in the history
…tHex functions (#4333)

* enh(NumberFormatter): Introduce backward compatible options for formatHex functions.

* enh(NumberFormatter): Corrections and improvements suggested in code review.

* fix(ci): disable testEncryptDecryptGCM on macOS which often fails.

* enh(NumberFormatter): Improved naming.
  • Loading branch information
matejk authored Dec 15, 2023
1 parent a464a4e commit 111fe90
Show file tree
Hide file tree
Showing 6 changed files with 532 additions and 198 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,13 @@ jobs:
CppUnit::TestCaller<ExpireLRUCacheTest>.testAccessExpireN,
CppUnit::TestCaller<UniqueExpireLRUCacheTest>.testExpireN,
CppUnit::TestCaller<ExpireLRUCacheTest>.testAccessExpireN,
CppUnit::TestCaller<SyslogTest>.testOldBSD"
CppUnit::TestCaller<SyslogTest>.testOldBSD,
CppUnit::TestCaller<PollSetTest>.testPollClosedServer,
CppUnit::TestCaller<CryptoTest>.testEncryptDecryptGCM"
EXCLUDE_TESTS="Redis Data/MySQL Data/ODBC Data/PostgreSQL MongoDB PDF"
./ci/runtests.sh
macos-clang-cmake:
macos-clang-cmake-openssl:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
Expand All @@ -240,7 +242,8 @@ jobs:
CppUnit::TestCaller<ExpireLRUCacheTest>.testAccessExpireN,
CppUnit::TestCaller<UniqueExpireLRUCacheTest>.testExpireN,
CppUnit::TestCaller<ExpireLRUCacheTest>.testAccessExpireN,
CppUnit::TestCaller<PollSetTest>.testPollClosedServer"
CppUnit::TestCaller<PollSetTest>.testPollClosedServer,
CppUnit::TestCaller<CryptoTest>.testEncryptDecryptGCM"
PWD=`pwd`
ctest --output-on-failure -E "(DataMySQL)|(DataODBC)|(PostgreSQL)|(MongoDB)|(Redis)"
Expand Down
6 changes: 6 additions & 0 deletions Crypto/testsuite/src/CryptoTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,12 @@ void CryptoTest::testEncryptDecryptDESECB()

void CryptoTest::testEncryptDecryptGCM()
{
//
// The test sometimes fails when it is running for longer time
// This conversation perhaps contains a hint:
// https://github.com/openssl/openssl/issues/21119
//

CipherKey key("aes-256-gcm");

CipherKey::ByteVec iv(20, 213);
Expand Down
Loading

0 comments on commit 111fe90

Please sign in to comment.