-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
#4170: Poco::FileStream is always opened with std::ios::in | std::ios…
…::out
- Loading branch information
1 parent
1db6fb9
commit 4244c32
Showing
2 changed files
with
21 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change breaks code that only specified
std::ios_base::binary
whenopen
ing aPoco::FileInputStream
. The_defaultMode
ofstd::ios::in
set when creating thePoco::FileInputStream
instance is lost resulting in a write-only stream by the implementation ofopen
inFileStream_POSIX.cpp
. On Win32 it will just result in a broken state when neither ofstd::ios::in
andstd::ios::out
are set.Example:
fis
will now be a write-only stream on POSIX and a broken stream on Win32.