-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2208 merge dnssd #4479
2208 merge dnssd #4479
Conversation
fixes #2208 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DNSSD does not compile on macOS with XCode and MacOSX14.4.sdk:
FindBounjour.cmake
does not set library and include variables on Apple platforms.
After fixing that (DNSSD is a part of CoreServices, no additional include directory required) compile fails because enum value kDNSServiceFlagsNonBrowsable
is not defined in Apple's dns_sd.h.
/Users/matejk/git/github/poco/DNSSD/Bonjour/src/BonjourResponderImpl.cpp:83:60: error: use of undeclared identifier 'kDNSServiceFlagsNonBrowsable'; did you mean 'kDNSServiceFlagsNoAutoRename'?
if (options & DNSSDResponder::REG_NON_BROWSABLE) flags |= kDNSServiceFlagsNonBrowsable;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
kDNSServiceFlagsNoAutoRename
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/dns_sd.h:286:5: note: 'kDNSServiceFlagsNoAutoRename' declared here
kDNSServiceFlagsNoAutoRename = 0x8,
^
It was removed in version 1096.0.2 (January 2020).
Older versions of dns_sd.h
from (https://github.com/apple-oss-distributions/mDNSResponder) still have this value.
kDNSServiceFlagsNonBrowsable = 0x2000,
/* A service registered with the NonBrowsable flag set can be resolved using
* DNSServiceResolve(), but will not be discoverable using DNSServiceBrowse().
* This is for cases where the name is actually a GUID; it is found by other means;
* there is no end-user benefit to browsing to find a long list of opaque GUIDs.
* Using the NonBrowsable flag creates SRV+TXT without the cost of also advertising
* an associated PTR record.
*/
replaces #4323