Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2208 merge dnssd #4479

Merged
merged 46 commits into from
Apr 3, 2024
Merged

2208 merge dnssd #4479

merged 46 commits into from
Apr 3, 2024

Conversation

aleks-f
Copy link
Member

@aleks-f aleks-f commented Mar 1, 2024

replaces #4323

@soroshsabz
Copy link
Contributor

fixes #2208

@aleks-f aleks-f requested a review from matejk March 29, 2024 21:41
CMakeLists.txt Show resolved Hide resolved
Copy link
Contributor

@matejk matejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNSSD does not compile on macOS with XCode and MacOSX14.4.sdk:

FindBounjour.cmake does not set library and include variables on Apple platforms.

After fixing that (DNSSD is a part of CoreServices, no additional include directory required) compile fails because enum value kDNSServiceFlagsNonBrowsable is not defined in Apple's dns_sd.h.


/Users/matejk/git/github/poco/DNSSD/Bonjour/src/BonjourResponderImpl.cpp:83:60: error: use of undeclared identifier 'kDNSServiceFlagsNonBrowsable'; did you mean 'kDNSServiceFlagsNoAutoRename'?
        if (options & DNSSDResponder::REG_NON_BROWSABLE) flags |= kDNSServiceFlagsNonBrowsable;
                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                  kDNSServiceFlagsNoAutoRename
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/dns_sd.h:286:5: note: 'kDNSServiceFlagsNoAutoRename' declared here
    kDNSServiceFlagsNoAutoRename        = 0x8,
    ^

It was removed in version 1096.0.2 (January 2020).

Older versions of dns_sd.h from (https://github.com/apple-oss-distributions/mDNSResponder) still have this value.

    kDNSServiceFlagsNonBrowsable        = 0x2000,
    /* A service registered with the NonBrowsable flag set can be resolved using
     * DNSServiceResolve(), but will not be discoverable using DNSServiceBrowse().
     * This is for cases where the name is actually a GUID; it is found by other means;
     * there is no end-user benefit to browsing to find a long list of opaque GUIDs.
     * Using the NonBrowsable flag creates SRV+TXT without the cost of also advertising
     * an associated PTR record.
     */

DNSSD/Bonjour/CMakeLists.txt Outdated Show resolved Hide resolved
@aleks-f aleks-f requested a review from matejk April 2, 2024 19:39
@aleks-f aleks-f merged commit b41f211 into devel Apr 3, 2024
42 checks passed
@aleks-f aleks-f deleted the 2208-merge-dnssd branch April 3, 2024 20:39
@soroshsabz
Copy link
Contributor

@aleks-f @matejk

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants