Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetSSL_OpenSSL and NetSSL_Win: non-blocking support, shutdown behavior fix #4787

Merged
merged 15 commits into from
Nov 29, 2024
Merged

NetSSL_OpenSSL and NetSSL_Win: non-blocking support, shutdown behavior fix #4787

merged 15 commits into from
Nov 29, 2024

Conversation

obiltschnig
Copy link
Member

@obiltschnig obiltschnig commented Nov 28, 2024 •
edited
Loading

This fixes a whole lot of issues in NetSSL_OpenSSL and NetSSL_Win.
Specifically:

  • we now have full support for non-blocking TLS sockets in both NetSSL_OpenSSL and NetSSL_Win
  • fixed TLS shutdown behavior, hopefully once and for all in both NetSSL_OpenSSL and NetSSL_Win
  • cleaned up and fixed NetSSL_Win, including workaround for Schannel bugs

@obiltschnig
fix(NetSSL): shutdown behavior
25ce194
@obiltschnig
fix(NetSSL_Win): shutdown behavior
e911884
@obiltschnig
chore(NetSSL_Win): refactored state machine (wip)
a48633b
@obiltschnig
chore(NetSSL_Win): remove select() calls from state machine
3c1c92c
@obiltschnig
chore(NetSSL_Win): use state machine also for blocking connections; f…
34852d1 
…ix non-blocking renegotiation
@obiltschnig
fix(NetSSL): handle EWOULDBLOCK when calling SSL_shutdown()
bc6ca86
@obiltschnig
chore(NetSSL_Win): rewrite handshake logic to support non-blocking so…
44ffffb 
…ckets
@obiltschnig
fix(NetSSL): shutdown behavior
1811f2f
@obiltschnig
fix(NetSSL_Win): shutdown behavior
5402032
@obiltschnig
chore(NetSSL_Win): refactored state machine (wip)
f1bb63a
@obiltschnig
chore(NetSSL_Win): remove select() calls from state machine
0bf3c15
@obiltschnig
chore(NetSSL_Win): use state machine also for blocking connections; f…
28a0843 
…ix non-blocking renegotiation
@obiltschnig
fix(NetSSL): handle EWOULDBLOCK when calling SSL_shutdown()
0eb2e1b
@obiltschnig
chore(NetSSL_Win): rewrite handshake logic to support non-blocking so…
663232b 
…ckets
@obiltschnig
Merge branch 'fix-ssl-shutdown' of github.com:pocoproject/poco into f…
e83119b 
…ix-ssl-shutdown
@obiltschnig obiltschnig self-assigned this Nov 28, 2024
@obiltschnig obiltschnig added this to the Release 1.14.0 milestone Nov 28, 2024
matejk
matejk approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@matejk matejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I don't feel fully competent for review, because I don't know all of the background. Some parts are complete rewrites.

@matejk matejk linked an issue Nov 28, 2024 that may be closed by this pull request
NetSSL_Win: TLS handshake may fail for non-blocking sockets #4779
Closed
@obiltschnig obiltschnig merged commit d8a423c into main Nov 29, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejk matejk matejk approved these changes

@aleks-f aleks-f Awaiting requested review from aleks-f

Assignees

@obiltschnig obiltschnig

Labels
bug feature
Projects
None yet
Milestone
Release 1.14.0
Development

Successfully merging this pull request may close these issues.

NetSSL_Win: TLS handshake may fail for non-blocking sockets
2 participants
@obiltschnig @matejk