-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2 (Android Plugin) Support #220
base: master
Are you sure you want to change the base?
Add v2 (Android Plugin) Support #220
Conversation
This adds v2 support for the new Android Plugin architecture that is compatible with Godot 4.2+ going forward.
Fixed paths that point to the output binaries.
Needed to add remote and local dependencies instead of separate configuration files. Added plugin file for GDScript users. Upgraded Gradle to newer version.
The wrong method was overridden and has been corrected. Successfully tested using C#.
thank you very much for the PR, we will test it soon |
Any updates on this? The current plugin works fine but it would be nice to have the new plugin architecture |
@rogerlopz I'll try to review and merge this PR this weekend |
Hello! can I ask where is this standing? I am using godot 4.2 and when I build to android I get error "PoingGodotAdMob not found, make sure you marked all 'PoingAdMob' plugins on export tab" |
Are there any plans on testing and merging this any time soon? |
@TheSkyOne I'm working on this right now. You can still use the plugin v1 on Godot 4.2 or higher, for that you need to: |
Thank you for updating. I am OK with waiting until you update the plugin to V2, just wanted to know if it was in the works. |
This adds v2 support for the new Android Plugin architecture that is compatible with Godot 4.2+ going forward.