-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise the minimum supported version of Observable
to iOS 17.0.1
#64
Raise the minimum supported version of Observable
to iOS 17.0.1
#64
Conversation
71edfdc
to
29e2d44
Compare
Sources/Perception/Macros.swift
Outdated
@available(macOS, deprecated: 14, renamed: "Observable") | ||
@available(tvOS, deprecated: 17, renamed: "Observable") | ||
@available(watchOS, deprecated: 10, renamed: "Observable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll want the same fix for other platforms. Wanna apply the following?
@available(macOS, deprecated: 14, renamed: "Observable") | |
@available(tvOS, deprecated: 17, renamed: "Observable") | |
@available(watchOS, deprecated: 10, renamed: "Observable") | |
@available(macOS, deprecated: 14.0.1, renamed: "Observable") | |
@available(tvOS, deprecated: 17.0.1, renamed: "Observable") | |
@available(watchOS, deprecated: 10.0.1, renamed: "Observable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd want to check whether the macOS one is necessary, as macOS 14 came out after iOS 17.0.1 (technically), so the bug may not exist there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I raised the tvOS and watchOS as you described, I have not modified macOS - please let me know if you would prefer that @stephencelis
0a52a8d
to
cffa3d3
Compare
cffa3d3
to
7b3133a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Obvervable
to iOS 17.0.1Observable
to iOS 17.0.1
Some users on iOS 17.0.0 are unable to use Composable Architecture due to a EXC_BAD_ACCESS crash when casting
subject
toany Observable
.This raises the minimum version to iOS 17.0.1 where the crash does not occur.
Slack Thread: https://pointfreecommunity.slack.com/archives/C04KQQ7NXHV/p1712927043813189