Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types and strengths to json #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add types and strengths to json #2

wants to merge 3 commits into from

Conversation

UshalNaidoo
Copy link

Add types and strengths to json

@ushal-AU
Fix Typo
8cce70f 
Fix typos of Pokemon
@ushal-AU
Added types and strengths to the json file
3f62494 
Added types and strengths to the json file
@donbailon
Copy link
Member

@UshalNaidoo thanks for your work!

You need to add a coma in the line 2715.

Thanks!

image

Sloy
Sloy reviewed Aug 11, 2016
View reviewed changes
app/src/main/assets/pokemons.json
"strengths": [
"fighting",
"grass",
"bug"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the missing comma

@Sloy
Copy link
Member

Sloy commented Aug 11, 2016

@UshalNaidoo thank you for the contribution :)
If you fix the missing comma in the Json file we will merge it

@UshalNaidoo
Added a missing comma
8929378 
Added a missing comma
@UshalNaidoo
Copy link
Author

Fixed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UshalNaidoo @donbailon @Sloy @ushal-AU