Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2P] Module-level background router peer discovery coverage #793

Draft
wants to merge 82 commits into
base: main
Choose a base branch
from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented May 29, 2023

Description

Adding module-level test coverage over the kademlia-backed peer discovery mechanism which the background router encapsulates.

Issue

Addresses most (if not all) deliverables in #712

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • ...

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@bryanchriswhite bryanchriswhite added p2p P2P specific changes testing Defining, adding, automating or modifying tests labels May 29, 2023
@bryanchriswhite bryanchriswhite self-assigned this May 29, 2023
@reviewpad reviewpad bot added the large Pull request is large label May 29, 2023
@bryanchriswhite bryanchriswhite changed the title [P2P] Module-level test coverage of background peer discovery (kad) [P2P] Module-level background router peer discovery coverage May 29, 2023
@bryanchriswhite bryanchriswhite linked an issue May 31, 2023 that may be closed by this pull request
11 tasks
@bryanchriswhite bryanchriswhite changed the base branch from test/refactor-testutils to feat/integrate-bg-router June 1, 2023 11:33
@bryanchriswhite bryanchriswhite force-pushed the feat/kad-peer-discovery branch from 4b5a5d2 to 66105a2 Compare June 1, 2023 11:33
@bryanchriswhite bryanchriswhite force-pushed the feat/kad-peer-discovery branch from 66105a2 to a00b9d1 Compare June 1, 2023 11:45
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a8206ec) 29.79% compared to head (a00b9d1) 29.79%.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/integrate-bg-router     #793   +/-   ##
=========================================================
  Coverage                     29.79%   29.79%           
=========================================================
  Files                           108      108           
  Lines                          8867     8867           
=========================================================
  Hits                           2642     2642           
  Misses                         5915     5915           
  Partials                        310      310           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bryanchriswhite bryanchriswhite force-pushed the feat/integrate-bg-router branch 12 times, most recently from 435c50c to 43cf671 Compare June 22, 2023 15:52
@bryanchriswhite bryanchriswhite force-pushed the feat/integrate-bg-router branch 5 times, most recently from b881b29 to 60cd2bd Compare June 29, 2023 13:33
Base automatically changed from feat/integrate-bg-router to main July 11, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large p2p P2P specific changes testing Defining, adding, automating or modifying tests
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[P2P] Background router peer discovery
1 participant