Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Refactor test helpers #797

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Conversation

bryanchriswhite
Copy link
Contributor

Description

(duplicate of #753, which was unintentionally closed)

Issue

Fixes #<issue_number>

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • ...

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@bryanchriswhite bryanchriswhite added the testing Defining, adding, automating or modifying tests label Jun 1, 2023
@bryanchriswhite bryanchriswhite self-assigned this Jun 1, 2023
@reviewpad reviewpad bot added the large Pull request is large label Jun 1, 2023
@bryanchriswhite bryanchriswhite linked an issue Jun 1, 2023 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large testing Defining, adding, automating or modifying tests
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Testing] Organize Pocket Repo TestUtils
1 participant