-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Development] Add LocalDev pod debugging #945
Draft
red-0ne
wants to merge
6
commits into
main
Choose a base branch
from
localnet-dlv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
infra
Core infrastructure - not protocol related
tooling
tooling to support development, testing et al
labels
Jul 27, 2023
Olshansk
requested changes
Jul 28, 2023
@red-0ne What is this still a draft? Asking to understand in review process. |
This still does not have dlv on lightweight localnet. I'm OK having this on k8s only for now and switch it as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add debugging capabilites to k8s LocalNet using dlv server and port forwarding.
Summary generated by Reviewpad on 04 Aug 23 08:24 UTC
This pull request includes the following changes:
kube_debug
which sets up a port-forwarding to a specific debugging pod.dlv
in theREADME.md
file.Tiltfile
to include a new entrypoint for thepocket-image
docker build, which enables debugging withdlv
.These changes aim to facilitate debugging and improve the development workflow for Pocket nodes.
Issue
Fixes #183
Type of change
Please mark the relevant option(s):
List of changes
TiltFile
to build pocket containers with dlv and start a debugging server topocket
binaryTesting
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)