Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utility] Add servicer module mock #960

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Aug 2, 2023

Description

Adds mock generation for the servicer module to support testing.

Issue

Part of work on #860

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Moved servicer module mock generation to its own file.
  • Updated references to the servicer module name

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@adshmh adshmh added the utility Utility specific changes label Aug 2, 2023
@adshmh adshmh added this to the M3: Pocket RoS (Relay or Slash) milestone Aug 2, 2023
@adshmh adshmh self-assigned this Aug 2, 2023
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 2, 2023
@adshmh adshmh requested review from dylanlott and h5law August 2, 2023 14:17
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adshmh I know I wasn't added as a reviewer on this originally, but noticed it was a small PR that's been open for a few days, so I went ahead and took a look.

shared/modules/utility_module.go Outdated Show resolved Hide resolved
@adshmh adshmh requested review from Olshansk and dylanlott August 9, 2023 18:54
@h5law h5law removed request for dylanlott and h5law December 10, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small utility Utility specific changes waiting-for-review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants