Skip to content

Commit

Permalink
chore: review feedback improvements
Browse files Browse the repository at this point in the history
Co-authored-by: harry <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
  • Loading branch information
3 people authored Dec 22, 2023
1 parent ef3cd99 commit 6e60952
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion x/supplier/client/cli/query_claim.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func CmdShowClaim() *cobra.Command {
Short: "shows a specific claim",
Long: `List a specific claim that the node being queried has access to (if it still exists).
A unique claim can be defined via a session_id that a given supplier participated in.
A unique claim can be defined via a session_id that the given supplier participated in.
Example:
$ poktrolld --home=$(POKTROLLD_HOME) q claim show-claims <session_id> <supplier_address> --node $(POCKET_NODE)`,
Expand Down
2 changes: 1 addition & 1 deletion x/supplier/keeper/msg_server_create_claim.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func (k msgServer) CreateClaim(goCtx context.Context, msg *suppliertypes.MsgCrea
2. [ ] msg distribution validation
*/

// Construct and insert claim after all validation.
// Construct and upsert claim after all validation.
claim := suppliertypes.Claim{
SupplierAddress: msg.GetSupplierAddress(),
SessionHeader: msg.GetSessionHeader(),
Expand Down
4 changes: 2 additions & 2 deletions x/supplier/types/query_validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func (query *QueryAllClaimsRequest) ValidateBasic() error {
// TODO_TECHDEBT: Validate the session ID once we have a deterministic way to generate it
logger.Warn().
Str("session_id", filter.SessionId).
Msg("TODO: SessionID check is currently a noop")
Msg("TODO: SessionID check in claim request validation is currently a noop")

case *QueryAllClaimsRequest_SessionEndHeight:
if filter.SessionEndHeight < 0 {
Expand All @@ -51,7 +51,7 @@ func (query *QueryAllClaimsRequest) ValidateBasic() error {

default:
// No filter is set
logger.Debug().Msg("No specific filter set")
logger.Debug().Msg("No specific filter set when requesting claims")
}
return nil
}

0 comments on commit 6e60952

Please sign in to comment.