[Supplier] feat: add staking_fee param to supplier module (#944)

## Summary

Add `staking_fee` param to the tokenomics module.

## Issue

- `TODO_BETA`

## Type of change

Select one or more from the following:

- [x] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [ ] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [x] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [x] I have tested my changes using the available tooling
- [ ] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [ ] I have left TODOs throughout the codebase, if applicable

---------

Co-authored-by: red-0ne <[email protected]>

config.yml

@@ -200,6 +200,10 @@ genesis:
         min_stake:
           amount: "1000000" # 1 POKT
           denom: upokt
+        # TODO_BETA(@bryanchriswhite): Determine realistic amount for supplier staking fee.
+        staking_fee:
+          amount: "1" # 1 uPOKT
+          denom: upokt
       supplierList:
         - owner_address: pokt19a3t4yunp0dlpfjrp7qwnzwlrzd5fzs2gjaaaj
           operator_address: pokt19a3t4yunp0dlpfjrp7qwnzwlrzd5fzs2gjaaaj

makefiles/params.mk

@@ -148,6 +148,10 @@ params_update_supplier_all: ## Update the supplier module params
 params_update_supplier_min_stake: ## Update the supplier module min_stake param
 	poktrolld tx authz exec ./tools/scripts/params/supplier_min_stake.json $(PARAM_FLAGS)
 
+.PHONY: params_update_supplier_staking_fee
+params_update_supplier_staking_fee: ## Update the supplier module staking_fee param
+	poktrolld tx authz exec ./tools/scripts/params/supplier_staking_fee.json $(PARAM_FLAGS)
+
 ### Session Module Params ###
 .PHONY: params_get_session
 params_get_session: ## Get the session module params

proto/poktroll/supplier/params.proto

@@ -16,4 +16,7 @@ message Params {
   // min_stake is the minimum amount of uPOKT that a supplier must stake to be
   // included in network sessions and remain staked.
   cosmos.base.v1beta1.Coin min_stake = 1 [(gogoproto.jsontag) = "min_stake", (gogoproto.moretags) = "yaml:\"min_stake\""];
+
+  // staking_fee is the fee charged by the protocol for staking a supplier.
+  cosmos.base.v1beta1.Coin staking_fee = 2 [(gogoproto.jsontag) = "staking_fee", (gogoproto.moretags) = "yaml:\"staking_fee\""];
 }

testutil/integration/suites/param_configs.go

@@ -1,8 +1,6 @@
 package suites
 
 import (
-	"encoding/hex"
-
 	cosmostypes "github.com/cosmos/cosmos-sdk/types"
 
 	"github.com/pokt-network/poktroll/app/volatile"
@@ -70,8 +68,8 @@ var (
 	ValidProofMissingPenaltyCoin       = cosmostypes.NewInt64Coin(volatile.DenomuPOKT, 500)
 	ValidProofSubmissionFeeCoin        = cosmostypes.NewInt64Coin(volatile.DenomuPOKT, 5000000)
 	ValidProofRequirementThresholdCoin = cosmostypes.NewInt64Coin(volatile.DenomuPOKT, 100)
-	ValidRelayDifficultyTargetHash, _  = hex.DecodeString("00000000ffffffffffffffffffffffffffffffffffffffffffffffffffffffff")
 	ValidActorMinStake                 = cosmostypes.NewInt64Coin(volatile.DenomuPOKT, 100)
+	ValidStakingFee                    = cosmostypes.NewInt64Coin(volatile.DenomuPOKT, 1)
 
 	SharedModuleParamConfig = ModuleParamConfig{
 		ParamsMsgs: ModuleParamsMessages{
@@ -192,7 +190,8 @@ var (
 			QueryParamsResponse:     suppliertypes.QueryParamsResponse{},
 		},
 		ValidParams: suppliertypes.Params{
-			MinStake: &ValidActorMinStake,
+			MinStake:   &ValidActorMinStake,
+			StakingFee: &ValidStakingFee,
 		},
 		ParamTypes: map[ParamType]any{
 			ParamTypeCoin: suppliertypes.MsgUpdateParam_AsCoin{},

tools/scripts/params/supplier_all.json

@@ -8,6 +8,10 @@
           "min_stake": {
             "amount": "1000000",
             "denom": "upokt"
+          },
+          "staking_fee": {
+            "amount": "1",
+            "denom": "upokt"
           }
         }
       }

tools/scripts/params/supplier_staking_fee.json

@@ -0,0 +1,15 @@
+{
+  "body": {
+    "messages": [
+      {
+        "@type": "/poktroll.supplier.MsgUpdateParam",
+        "authority": "pokt10d07y265gmmuvt4z0w9aw880jnsr700j8yv32t",
+        "name": "staking_fee",
+        "as_coin": {
+          "amount": "1",
+          "denom": "upokt"
+        }
+      }
+    ]
+  }
+}

x/supplier/keeper/msg_server_update_param.go

@@ -38,6 +38,9 @@ func (k msgServer) UpdateParam(ctx context.Context, msg *suppliertypes.MsgUpdate
 	case suppliertypes.ParamMinStake:
 		logger = logger.With("min_stake", msg.GetAsCoin())
 		params.MinStake = msg.GetAsCoin()
+	case suppliertypes.ParamStakingFee:
+		logger = logger.With("staking_fee", msg.GetAsCoin())
+		params.StakingFee = msg.GetAsCoin()
 	default:
 		return nil, status.Error(
 			codes.InvalidArgument,

x/supplier/keeper/msg_update_params_test.go

@@ -3,8 +3,10 @@ package keeper_test
 import (
 	"testing"
 
+	cosmostypes "github.com/cosmos/cosmos-sdk/types"
 	"github.com/stretchr/testify/require"
 
+	"github.com/pokt-network/poktroll/app/volatile"
 	suppliertypes "github.com/pokt-network/poktroll/x/supplier/types"
 )
 
@@ -13,6 +15,8 @@ func TestMsgUpdateParams(t *testing.T) {
 	params := suppliertypes.DefaultParams()
 	require.NoError(t, k.SetParams(ctx, params))
 
+	zerouPokt := cosmostypes.NewInt64Coin(volatile.DenomuPOKT, 0)
+
 	// default params
 	tests := []struct {
 		desc           string
@@ -42,7 +46,8 @@ func TestMsgUpdateParams(t *testing.T) {
 			params: &suppliertypes.MsgUpdateParams{
 				Authority: k.GetAuthority(),
 				Params: suppliertypes.Params{
-					MinStake: &suppliertypes.DefaultMinStake,
+					MinStake:   &suppliertypes.DefaultMinStake,
+					StakingFee: &zerouPokt,
 				},
 			},
 			shouldError: false,