Skip to content

Commit

Permalink
[Code Health] mitigate protobuf import issue (#749)
Browse files Browse the repository at this point in the history
## Summary

Renames all .proto files which are named the same as their protobuf
package to workaround/mitigate an issue which presents when importing
them in other .proto files.

## Issue

- Potentially related to (but **does not** fix) #405 

![Screenshot 2024-08-21 at 3 39
51 PM](https://github.com/user-attachments/assets/6a7d1d2a-daba-424c-a930-d065061fe4d2)


## Type of change

Select one or more:

- [ ] New feature, functionality or library
- [ ] Bug fix
- [x] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [x] **Unit Tests**: `make go_develop_and_test`
- [x] **LocalNet E2E Tests**: `make test_e2e`
- [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [x] I have tested my changes using the available tooling
- [ ] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [x] I have left TODOs throughout the codebase, if applicable
  • Loading branch information
bryanchriswhite authored Aug 22, 2024
1 parent 2788178 commit b2d91c5
Show file tree
Hide file tree
Showing 68 changed files with 4,254 additions and 4,769 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,8 @@ test_e2e_gateway: test_e2e_env ## Run only the E2E suite that exercises the gate
test_e2e_session: test_e2e_env ## Run only the E2E suite that exercises the session (i.e. claim/proof) life-cycle
go test -v ./e2e/tests/... -tags=e2e,test --features-path=session.feature

.PHONY: test_e2e_settlement
test_e2e_settlement: test_e2e_env ## Run only the E2E suite that exercises the session & tokenomics settlement
.PHONY: test_e2e_tokenomics
test_e2e_tokenomics: test_e2e_env ## Run only the E2E suite that exercises the session & tokenomics settlement
go test -v ./e2e/tests/... -tags=e2e,test --features-path=0_settlement.feature

.PHONY: test_e2e_params
Expand Down
116 changes: 58 additions & 58 deletions api/poktroll/application/genesis.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions api/poktroll/application/params.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b2d91c5

Please sign in to comment.