Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppGate] Implement the MVP AppGateServer #108
[AppGate] Implement the MVP AppGateServer #108
Changes from 27 commits
cec3ef4
d312423
c4fe2da
a6edf61
aab9e17
0f2a53f
65c524f
6e265c2
a966b66
80af5fb
c1f6115
c681484
c787d80
65e9bee
c22dc9c
c14a8b6
ec57a8e
ba3bd8f
781ee13
078be29
00211a9
12d97d6
2591e19
3f2cb90
a857e5f
bc2efb3
76a31c0
09c843c
151313e
2cd04e7
5daed4a
d8c668a
118d26d
ce91371
969bf0f
211df7f
89786c3
b6f7ef5
1d9c233
89688ab
683b285
35936ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 47 in pkg/appgateserver/cmd/cmd.go
GitHub Actions / misspell
[misspell] pkg/appgateserver/cmd/cmd.go#L47
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h5law My understanding was that the presence of
signing-key-name
is what determines this, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is not the case, in fact for both gateways and applications they need a key to sign with:
signing-key
(removed the name)However, gateways do not "self-sign" instead they "others-sign" but applications do "self-sign". This means that if an appgate server is started and declares it will "self-sign" for every request it will fetch its own ring and sign it that way.
If it doesnt opt to "self sign" for every request it will fetch the ring of the application address it is provided, but it will still have to sign the ring with its
signing-key
.Does that clear it up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I'd say #PUC right next to the flag definitions!
Check warning on line 72 in pkg/appgateserver/cmd/cmd.go
GitHub Actions / misspell
[misspell] pkg/appgateserver/cmd/cmd.go#L72
Raw output