Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service] Rename the ServiceId proto to Service #150

Merged
merged 19 commits into from
Nov 8, 2023
Merged

[Service] Rename the ServiceId proto to Service #150

merged 19 commits into from
Nov 8, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Nov 7, 2023 •
edited
Loading

Summary

Renamed the ServiceId proto to Service so ServiceId.Id is more semantic and less confusing.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@Olshansk Olshansk changed the title Beginning to rename ServiceId to Service [Service] Rename the ServiceId proto to Service Nov 7, 2023
@Olshansk Olshansk self-assigned this Nov 7, 2023
@Olshansk Olshansk mentioned this pull request Nov 7, 2023
Closed
10 tasks
@Olshansk Olshansk added the service Anything related to general-purpose RPC service support label Nov 7, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Nov 7, 2023
Olshansk and others added 7 commits November 7, 2023 11:24
@Olshansk @bryanchriswhite
Update pkg/relayer/proxy/interface.go
a54c90e 
Co-authored-by: Bryan White <[email protected]>
@Olshansk @bryanchriswhite
Update pkg/relayer/proxy/jsonrpc.go
cbd39ab 
Co-authored-by: Bryan White <[email protected]>
@Olshansk @bryanchriswhite
Update proto/pocket/shared/service.proto
a5e7986 
Co-authored-by: Bryan White <[email protected]>
@Olshansk @bryanchriswhite
Update x/shared/helpers/service_test.go
5ddb28e 
Co-authored-by: Bryan White <[email protected]>
@Olshansk @bryanchriswhite
Update x/supplier/keeper/supplier.go
a33b42e 
Co-authored-by: Bryan White <[email protected]>
@Olshansk @bryanchriswhite
Update pkg/relayer/proxy/jsonrpc.go
16c8145 
Co-authored-by: Bryan White <[email protected]>
@bryanchriswhite @Olshansk
fix: flaky block client test (#132)
d204d14 
* fix: flakey block cliekt test

* chore: simplify & react to review feedback

* chore: add godoc comment

* chore: simplify
okdas and others added 7 commits November 7, 2023 11:31
@okdas @Olshansk
[CI] Build container images (#107)
21edfe7 
* wip - need info from GitHub CI

* build image as a part of main ci

* troublshoot w/o test

* should be a cp here

* wip

* more label control

* install directly from github

* use wget

* rerun ci

* troubleshoot

* more information

* it was git context

* kill previous run if a new commit is pushed

* this should work

* remove buildlog

* resolve conflicts

* perform the tests as well

* we will be allright withoug keeping the bin dir

* bring back ignite version

* also build on mai

* refine label actions

* Update .github/workflows/go.yml

Co-authored-by: Daniel Olshansky <[email protected]>

* add requested changes

* pocketd has been replaced with poktrolld

* only change the binary name for now, take care of other pocketd instances later

* Update .github/label-actions.yml

Co-authored-by: Daniel Olshansky <[email protected]>

* rename pocketd with poktrolld where necessary

* typofix

* also use poktrolld for e2e tests

---------

Co-authored-by: Daniel Olshansky <[email protected]>
@bryanchriswhite @Olshansk
[Miner] feat: add TxClient (#94)
51ae802 
* chore: add `TxClient` interface

* chore: add option support to `ReplayObservable`

* feat: add `txClient` implementation

* test: `txClient`

* test: tx client integration

* chore: s/tx/transaction/g

* chore: update pkg README.md template

* wip: client pkg README

* docs: fix client pkg godoc comment

* fix: flakey test

* chore: dial back godoc comments 😅

* chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment

* chore: update go.mod

* chore: refactor & condense godoc comments

* chore: fix import paths post-update

* chore: review feedback improvements

* docs: update client README.md

* docs: add `tx query` usage association between `txContext` & `Blockchain`

* docs: add TOC

* chore: review feedback improvements

Co-authored-by: Daniel Olshansky <[email protected]>

* docs: improve godoc comments & client README.md

---------

Co-authored-by: Daniel Olshansky <[email protected]>
@bryanchriswhite @Olshansk
[Off-chain] refactor: keyring errors & helpers (#131)
36b6de2 
* chore: add `TxClient` interface

* chore: add option support to `ReplayObservable`

* feat: add `txClient` implementation

* test: `txClient`

* test: tx client integration

* chore: s/tx/transaction/g

* chore: update pkg README.md template

* wip: client pkg README

* docs: fix client pkg godoc comment

* refactor: consolidate keyring errors & helpers

* refactor: keyring test helpers

* fix: flakey test

* chore: dial back godoc comments 😅

* chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment

* chore: update go.mod

* chore: refactor & condense godoc comments

* chore: fix import paths post-update
@bryanchriswhite @Olshansk
[Miner] feat: add supplier client (#42)
5496e42 
* chore: add `TxClient` interface

* chore: add option support to `ReplayObservable`

* feat: add `txClient` implementation

* test: `txClient`

* test: tx client integration

* chore: s/tx/transaction/g

* chore: update pkg README.md template

* wip: client pkg README

* docs: fix client pkg godoc comment

* refactor: consolidate keyring errors & helpers

* refactor: keyring test helpers

* fix: flakey test

* chore: dial back godoc comments 😅

* chore: add `SupplierClient` interface

* feat: add supplier client implementation

* test:  supplier test helpers

* test: supplier client tests

* test: supplier client integration test

* chore: update go.mod

* trigger CI

* chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment

* chore: update go.mod

* chore: refactor & condense godoc comments

* chore: fix import paths post-update

* chore: add godoc comment
@Olshansk
Fixed some tests based on bryan's comments
4d49a1a
@Olshansk
Fix lingering serviceId rename
ee3d8cb
@Olshansk
Merge with main again
39e1f3c
@Olshansk
Copy link
Member Author

Olshansk commented Nov 7, 2023 •
edited
Loading

@bryanchriswhite Thank you for the thorough review!

I went ahead and resolved everything (no inline comments) so PTAL again when you have a chance 🙏

@Olshansk Olshansk mentioned this pull request Nov 7, 2023
Merged
10 tasks
bryanchriswhite
bryanchriswhite approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🙌🚢

@red-0ne red-0ne mentioned this pull request Nov 8, 2023
Merged
10 tasks
@Olshansk Olshansk merged commit 823262a into main Nov 8, 2023
7 checks passed
Olshansk added a commit that referenced this pull request Nov 8, 2023
@Olshansk @bryanchriswhite @okdas
[Service] Rename the ServiceId proto to Service (#150)
cbc8e8a 
Renamed the `ServiceId` proto to `Service` so `ServiceId.Id` is more semantic and less confusing.
---

Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: Dima Kniazev <[email protected]>
okdas added a commit that referenced this pull request Nov 14, 2024
@Olshansk @bryanchriswhite @okdas
[Service] Rename the ServiceId proto to Service (#150)
75eb643 
Renamed the `ServiceId` proto to `Service` so `ServiceId.Id` is more semantic and less confusing.
---

Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: Dima Kniazev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanchriswhite bryanchriswhite bryanchriswhite approved these changes

@red-0ne red-0ne Awaiting requested review from red-0ne

Assignees

@Olshansk Olshansk

Labels
service Anything related to general-purpose RPC service support
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
Development

Successfully merging this pull request may close these issues.
3 participants
@Olshansk @bryanchriswhite @okdas