[E2E relay test] Update to #178 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RelayerOption parameter
- Fixed helpers for localnet regenesis - Added an application & supplier to the genesis file - Initializing appMap & supplierMap in E2E tests - Add support for the app's codec (for unmarshaling responses) in E2E tests - Adding a placeholder for `e2e/tests/relay.feature` --- Co-authored-by: harry <[email protected]>
* refactor: `MapFn`s receive context arg * feat: add `MapExpand` observable operator * refactor: `RelayerSessionsManager` to be more reactive * chore: add godoc comment * chore: review feedback improvements * trigger CI
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
* relayer/cli: fix: supplier client test chore: add long command description chore: review feedback improvements chore: review feedback improvements fix: sessiontree store path check fix: sessiontree store path check refactor: separate tx and query client contexts 🙄 refactor: relayminer depinject helpers & godoc comments on all constructors chore: review feedback improvements chore: update anvil service port in make targets
…-update * merge/e2e_test/relay_x_relayer_cli: fix: supplier client test chore: add long command description chore: review feedback improvements chore: review feedback improvements fix: sessiontree store path check fix: sessiontree store path check refactor: separate tx and query client contexts 🙄 refactor: relayminer depinject helpers & godoc comments on all constructors chore: review feedback improvements chore: update anvil service port in make targets
Olshansk
approved these changes
Nov 16, 2023
* relayer/cli: More tiny comment updates Added a couple more comments Update some comments and TODOs Update the names and references to queryNode/sequencerNode/fullNode etc Update pkg/relayer/cmd/cmd.go [Test] Updating `relay.feature` to run curl command to enable E2E Relay Test (#178) Updated comments for post 177+179 work for okdas Update OpenAPI spec Update .gitignore chore: update comment chore: move shared dependency setup logic to shared pkg chore: cleanup flags and dependencies for appgateserver cmd [Supplier] chore: improve supplier not found error message (#183) [CI] Integrate E2E tests with GitHub CI (#152)
…-update * merge/e2e_test/relay_x_relayer_cli: [LocalNet] Run Relayer and AppGateServer (#179) [Relay] E2E Relay Gaps (#177) More tiny comment updates Added a couple more comments Update some comments and TODOs Update the names and references to queryNode/sequencerNode/fullNode etc Update pkg/relayer/cmd/cmd.go [Test] Updating `relay.feature` to run curl command to enable E2E Relay Test (#178) Updated comments for post 177+179 work for okdas Update OpenAPI spec Update .gitignore chore: update comment chore: move shared dependency setup logic to shared pkg chore: cleanup flags and dependencies for appgateserver cmd [Supplier] chore: improve supplier not found error message (#183) [CI] Integrate E2E tests with GitHub CI (#152)
bryanchriswhite
changed the base branch from
merge/e2e_test/relay_x_relayer_cli
to
main
Co-authored-by: Daniel Olshansky <[email protected]>
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
* refactor: `MapFn`s receive context arg * chore: add `ForEach` map shorthand operator * chore: add `/pkg/observable/filter` * chore: add `/pkg/observable/logging` * chore: add `/pkg/relayer/protocol` * chore: add `Miner` interface * feat: add `Miner` implementation * test: `Miner` implementation * chore: fix comment * chore: add godoc comments * feat: Add Relayer struct * chore: Rename to RelayMiner * chore: Rename relay miner file * chore: Remove unused RelayerOption parameter * [Test] First step for automated E2E Relay test (#167) - Fixed helpers for localnet regenesis - Added an application & supplier to the genesis file - Initializing appMap & supplierMap in E2E tests - Add support for the app's codec (for unmarshaling responses) in E2E tests - Adding a placeholder for `e2e/tests/relay.feature` --- Co-authored-by: harry <[email protected]> * [Relayer] refactor: simplify `RelayerSessionsManager` (#169) * refactor: `MapFn`s receive context arg * feat: add `MapExpand` observable operator * refactor: `RelayerSessionsManager` to be more reactive * chore: add godoc comment * chore: review feedback improvements * trigger CI * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * chore: review feedback improvements * chore: update start mining comment * fix: Update Miner interface * fix: import cycle & goimports * chore: review feedback improvements * chore: cleanup TODO_THIS_COMMIT comments * chore: improve var & func names for clarity and consistency * refactor: move claim/proof lifecycle concerns to `relayerSessionsManager`. * chore: review feedback improvements * chore: review feedback improvements * refactor: `miner#hash()` method * chore: tidy up * chore: simplify * wip: relayer CLI * chore: finish first pass * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * chore: review feedback improvements * chore: review feedback improvements * chore: tidy up cmd creation * fix: incomplete refactor * chore: simplify * chore: add log lines * wip: react to miner, refactor, construct miner, refactor * chore: cleanup * chore: Reflect responsibility changes of session manager * feat: Use relay miner to start * [WIP] Updating relay.feature to run curl command * chore: Improve comment about startig relayer proxy * wip: debugging * Continued implementation but still failing * Getting an invalid request right now but figuring it out... * wip: debugging * Added service and switched to AppGate * wip: debugging * chore: Rename falg variables * wip: debugging * revertme: disable tilt relayer service * chore: use arg not flag * chore: rename command * Debugging checkpoint * wip: debugging - improvments * wip: debugging * wip: debugging * wip: debugging * revert-or-fixme: add error log lines * revert-or-fixme: add debug log lines * fix: set relay server handle function * revert-or-fixme: add debug log lines * chore: rename some chan vars * feat: fix all bugs, e2e relay works * chore: add some todo comments * wip: debugging * fix: use remote helm charts again * fix: put adequate proxied services endpoitns, prevent session republishing * chore: Refactor JSONRPCServer and server builder * Upate a couple small comments in the maketfile * revert: comment relayers out of tiltfile * chore: fix subcmd name `relayerminer` -> `relayminer` * chore: improve logging * chore: cleanup error messaging & logging in appgate server * refactor: rename misnamed `jsonRPCServer` receiver var * chore: remove appgate server debug log * chore: unexport `relayMiner` struct * refactor: interrupt signal handling * chore: improve comments * chore: improve comments * revert: tiltfile hot-reload dirs * refactor: re-consolidate client contexts * fix: typo * chore: remove todo * chore: add todo comment * revert: comment change * fix: error format strings * chore: remove comment * fix: error format strings * chore: add `-features-path` flag to cucumber tests * fix: set the relayminer URL in the curl cmd * chore: remove redundant `-X` curl arg (says curl) * squash: fix relayminer url: reword: s/relayminer/appgateserver/ * chore: improve error messaging * fix: curl invocation * test: implement step definition to assert agains relay response * chore: improve error name & messaging * Self review * fixup: merge upstream * chore: review feedback improvements * chore: update anvil service port in make targets * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * refactor: relayminer depinject helpers & godoc comments on all constructors * refactor: separate tx and query client contexts 🙄 * fix: sessiontree store path check * fix: sessiontree store path check * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * chore: review feedback improvements * chore: add long command description * fix: supplier client test * chore: cleanup flags and dependencies for appgateserver cmd * chore: move shared dependency setup logic to shared pkg * chore: update comment * Update .gitignore * Update OpenAPI spec * Updated comments for post 177+179 work for okdas * Update pkg/relayer/cmd/cmd.go * Update the names and references to queryNode/sequencerNode/fullNode etc * Update some comments and TODOs * Added a couple more comments * More tiny comment updates * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> --------- Co-authored-by: Redouane Lakrache <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: harry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
This PR is based on a branch that merges #178,
main, and #177 and builds on top to get an E2E relay test passing (and failing) for the right reasons.-features-pathflag to the E2E go test such that we can select (via glob pattern) which features we want to run on invocation.TheApplicationReceivesASuccessfulRelayResponseSignedBy.To run the relay test (outside of tilt):
AI Summary
Summary generated by Reviewpad on 14 Nov 23 16:09 UTC
This pull request includes the following changes:
flagpackage importfeaturesPathFlagandkeyRingFlagvariablesfeatures-pathflag inTestMainfunctionTheApplicationSendsTheSupplierARequestForServiceWithDatafunction toTheApplicationSendsTheSupplierARequestForServiceWithDataand added code commentsgetRelayKeyfunctionTheApplicationReceivesASuccessfulRelayResponseSignedByfunctionrunCurlPostCmdfunction inpocketdBinstructErrAppGateEmptyRelayResponseconstantverifyResponsefunction inappGateServerstructVerifyRelayRequestfunction inrelayerProxystructIssue
Relates to:
relay.featureto run curl command to enable E2E Relay Test #178It would be really useful to have the E2E relay test working already such that we can quickly and easily tell if the integration has regressed to a broken state. This should close that loop.
Type of change
Select one or more:
Testing
make go_develop_and_testSanity Checklist