Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Introduce Docusaurus documentation #252

Merged
merged 45 commits into from
Dec 20, 2023
Merged

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Dec 9, 2023

Summary

Introduce the first iteration of dev.poktroll.com using docusarus while also adding a quickstart guide.

Screen.Recording.2023-12-10.at.5.20.05.PM.mov

Changes

Introduce Docusaurus.io documentation using the .md files in this repo. Also:

  • Add a basic quickstart guide
  • Add a basic contribution guide
  • Move over existing documents
  • Add a few admonitions with warning signs & tips
  • GitHub action to automatically deploy it on merges to main

Did not do in this PR:

  • Align the architecture docs with the most up to date architecture
  • Review all existing (moved over) docs from start to finish

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

make docusaurus_start

@Olshansk Olshansk added the documentation Improvements or additions to documentation label Dec 9, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Dec 9, 2023
@Olshansk Olshansk self-assigned this Dec 9, 2023
@Olshansk Olshansk changed the title WIP [WIP] Introduce Docusaurus documentation Dec 9, 2023
Makefile Show resolved Hide resolved
docusaurus/docs/contributing/contributing.md Show resolved Hide resolved
docusaurus/docs/README.md Outdated Show resolved Hide resolved
@Olshansk Olshansk force-pushed the docs/hello_poktroll branch from eff643d to 3e7e35a Compare December 13, 2023 19:54
Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) We do need to address TODO_IN_THIS_PR first, though.

@Olshansk Olshansk changed the title [WIP] Introduce Docusaurus documentation [Docs] Introduce Docusaurus documentation Dec 19, 2023
@Olshansk Olshansk marked this pull request as ready for review December 19, 2023 21:51
@Olshansk Olshansk removed the request for review from bryanchriswhite December 19, 2023 21:53
@Olshansk
Copy link
Member Author

@h5law I added an npm_check and a node_check so hopefully that captures what you were thinking.

@okdas I tended to the techdebt I added and updated a couple minor things.

I think we should merge this as is (good enough) to act as a starting point and will update based on feedback we get from our first users.

Copy link
Contributor

@h5law h5law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM LFGGGGG 🦖

Copy link
Contributor

@h5law h5law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM LFGGGGG 🦖

@Olshansk Olshansk merged commit de028c6 into main Dec 20, 2023
9 of 10 checks passed
@Olshansk Olshansk deleted the docs/hello_poktroll branch December 20, 2023 19:25
Olshansk added a commit that referenced this pull request Dec 21, 2023
bryanchriswhite added a commit that referenced this pull request Dec 22, 2023
…im-proof

* pokt/main:
  Fix bug introduced by #252 where genesis file was no longer being copied to the right location
  [Docs] Introduce Docusaurus documentation (#252)
  [Cleanup] Centralzie websocket url -> endpoint changes (#272)
  refactor: `NewMinedRelay` to shared testutil (#262)
  fix: PR template typo 2 (#269)
  [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253)
  [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
bryanchriswhite added a commit that referenced this pull request Dec 22, 2023
…or/supplier-keys

* issues/141/refactor/claim-proof:
  chore: review feedback improvements
  chore: review feedback improvements
  Fix bug introduced by #252 where genesis file was no longer being copied to the right location
  [Docs] Introduce Docusaurus documentation (#252)
  [Cleanup] Centralzie websocket url -> endpoint changes (#272)
  refactor: `NewMinedRelay` to shared testutil (#262)
  fix: PR template typo 2 (#269)
  [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253)
  [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
bryanchriswhite added a commit that referenced this pull request Dec 22, 2023
…ctor/supplier-errors

* issues/141/refactor/supplier-keys:
  chore: review feedback improvements
  chore: review feedback improvements
  Fix bug introduced by #252 where genesis file was no longer being copied to the right location
  [Docs] Introduce Docusaurus documentation (#252)
  [Cleanup] Centralzie websocket url -> endpoint changes (#272)
  refactor: `NewMinedRelay` to shared testutil (#262)
  fix: PR template typo 2 (#269)
  [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253)
  [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
okdas added a commit that referenced this pull request Nov 14, 2024
Introduce the first iteration of dev.poktroll.com using docusarus while also adding a quickstart guide.

Done in this PR:
- [x] Introduce Docusaurus.io documentation using the `.md` files in this repo
- [x] Add a basic quickstart guide
- [x] Add a basic contribution guide
- [x] Move over existing documents
- [x] Add a few admonitions with warning signs & tips
- [x] GitHub action to automatically deploy it on merges to main

Not done in this PR:
- Align the architecture docs with the most up to date architecture
- Review all existing (moved over) docs from start to finish

Video reference: https://github.com/pokt-network/poktroll/assets/1892194/801a1859-4060-434e-b03e-

---------

Co-authored-by: DK <[email protected]>
Co-authored-by: h5law <[email protected]>
okdas pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants