Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing, Code Health] refactor: NewMinedRelay to shared testutil #262

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[Testing, Code Health] refactor: NewMinedRelay to shared testutil #262

merged 1 commit into from
Dec 14, 2023

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Dec 12, 2023 •
edited
Loading

Summary

Human Summary

Moves and exports NewMinedRelay() test helper to a testrelayer package.

AI Summary

Summary generated by Reviewpad on 13 Dec 23 14:00 UTC

This pull request refactors NewMinedRelay to the shared testutil package. It moves the function from pkg/relayer/session/session_test.go to testutil/testrelayer/relays.go. This change simplifies the code structure and promotes code reuse.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • **Run E2E tests on DevNet: Add the devnet-test-e2e` label to the PR. This is VERY expensive, o only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@bryanchriswhite bryanchriswhite added testing Test (or test utils) additions, fixes, improvements or other code health Cleans up some code labels Dec 12, 2023
@bryanchriswhite bryanchriswhite added this to the Shannon TestNet milestone Dec 12, 2023
@bryanchriswhite bryanchriswhite self-assigned this Dec 12, 2023
@bryanchriswhite bryanchriswhite mentioned this pull request Dec 12, 2023
Closed
10 tasks
@bryanchriswhite bryanchriswhite linked an issue Dec 13, 2023 that may be closed by this pull request
[Protocol] MVP implementation off the on-chain SubmitProof message handling #141
Closed
8 tasks
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/testutil branch from 6fb3362 to 4bcd8de Compare December 13, 2023 14:00
@bryanchriswhite bryanchriswhite marked this pull request as ready for review December 13, 2023 14:01
@bryanchriswhite bryanchriswhite merged commit df73cfa into main Dec 14, 2023
10 checks passed
h5law added a commit that referenced this pull request Dec 14, 2023
@h5law
squash: merge with main
79dd438 
commit df73cfa
Author: Bryan White <[email protected]>
Date:   Thu Dec 14 01:06:03 2023 +0100

    refactor: `NewMinedRelay` to shared testutil (#262)

commit 410965a
Author: Bryan White <[email protected]>
Date:   Thu Dec 14 01:05:52 2023 +0100

    fix: PR template typo 2 (#269)

commit dd7df68
Author: Daniel Olshansky <[email protected]>
Date:   Wed Dec 13 13:45:26 2023 -0800

    [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253)

    This is aiming to fix multiple issues in E2E tests and just general QoL improvements:

    1. Adding a comment in `relay.feature` about the need to run `make supplier1_stake && make app1_stake` until we fix #180 (known issue)
    2. Replacing the reference to host `sequencer-poktroll-sequencer` with `localhost` (see first screenshot below)
    3. Fixed a bug leading us to assert against a `MsgSubmitProof` event instead of a `MsgCreateClaim` event (see second screenshot below)
    4. Fixed on-chain logging under `x/*` by replacing `logger\.(Info|Error)\("([^"]+)"(?:, (.*))?\)` with `logger.$1(fmt.Sprintf("$2", $3))` so it works as expected
    5. Some quality-of-life comments & TODOs
    6. Minor additions to unit tests from #220

commit d621631
Author: Redouane Lakrache <[email protected]>
Date:   Wed Dec 13 16:24:34 2023 +0100

    [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)

    * feat: Have distinct JSON-RPC and gRPC urls

    * chore: Trigger e2e tests

    * chore: Fix import groups

commit 4e30e27
Author: Bryan White <[email protected]>
Date:   Wed Dec 13 14:28:36 2023 +0100

    fix PR template testing checklist item (#268)
okdas pushed a commit that referenced this pull request Dec 19, 2023
@bryanchriswhite @okdas
refactor: NewMinedRelay to shared testutil (#262)
21a71da
bryanchriswhite added a commit that referenced this pull request Dec 22, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/141/refactor/cla…
7994ca2 
…im-proof

* pokt/main:
  Fix bug introduced by #252 where genesis file was no longer being copied to the right location
  [Docs] Introduce Docusaurus documentation (#252)
  [Cleanup] Centralzie websocket url -> endpoint changes (#272)
  refactor: `NewMinedRelay` to shared testutil (#262)
  fix: PR template typo 2 (#269)
  [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253)
  [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
bryanchriswhite added a commit that referenced this pull request Dec 22, 2023
@bryanchriswhite
Merge branch 'issues/141/refactor/claim-proof' into issues/141/refact…
6a5b3e6 
…or/supplier-keys

* issues/141/refactor/claim-proof:
  chore: review feedback improvements
  chore: review feedback improvements
  Fix bug introduced by #252 where genesis file was no longer being copied to the right location
  [Docs] Introduce Docusaurus documentation (#252)
  [Cleanup] Centralzie websocket url -> endpoint changes (#272)
  refactor: `NewMinedRelay` to shared testutil (#262)
  fix: PR template typo 2 (#269)
  [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253)
  [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
bryanchriswhite added a commit that referenced this pull request Dec 22, 2023
@bryanchriswhite
Merge branch 'issues/141/refactor/supplier-keys' into issues/141/refa…
0351cc7 
…ctor/supplier-errors

* issues/141/refactor/supplier-keys:
  chore: review feedback improvements
  chore: review feedback improvements
  Fix bug introduced by #252 where genesis file was no longer being copied to the right location
  [Docs] Introduce Docusaurus documentation (#252)
  [Cleanup] Centralzie websocket url -> endpoint changes (#272)
  refactor: `NewMinedRelay` to shared testutil (#262)
  fix: PR template typo 2 (#269)
  [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253)
  [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
okdas pushed a commit that referenced this pull request Nov 14, 2024
@bryanchriswhite
refactor: NewMinedRelay to shared testutil (#262)
0c41c05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk approved these changes

Assignees

@bryanchriswhite bryanchriswhite

Labels
code health Cleans up some code testing Test (or test utils) additions, fixes, improvements or other
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
Development

Successfully merging this pull request may close these issues.

[Protocol] MVP implementation off the on-chain SubmitProof message handling
2 participants
@bryanchriswhite @Olshansk