-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing, Tooling] refactor: in-memory network usage #285
Merged
bryanchriswhite
merged 8 commits into
issues/141/feat/in-memory-network
from
issues/141/refactor/in-memory-network
Jan 9, 2024
Merged
[Testing, Tooling] refactor: in-memory network usage #285
bryanchriswhite
merged 8 commits into
issues/141/feat/in-memory-network
from
issues/141/refactor/in-memory-network
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
testing
Test (or test utils) additions, fixes, improvements or other
tooling
Tooling - CLI, scripts, helpers, off-chain, etc...
labels
Dec 19, 2023
11 tasks
bryanchriswhite
force-pushed
the
issues/141/refactor/in-memory-network
branch
3 times, most recently
from
December 21, 2023 18:40
45d83a6
to
d6ae216
Compare
bryanchriswhite
changed the base branch from
issues/141/refactor/supplier-errors
to
issues/141/prep/in-memory-network
December 21, 2023 18:47
bryanchriswhite
changed the base branch from
issues/141/prep/in-memory-network
to
issues/141/feat/in-memory-network
December 21, 2023 18:48
bryanchriswhite
changed the title
[Testing, Tooling] refactor: in-memory network
[Testing, Tooling] refactor: in-memory network usage
Dec 21, 2023
11 tasks
bryanchriswhite
force-pushed
the
issues/141/feat/in-memory-network
branch
from
December 21, 2023 20:16
50c62d9
to
a8a9cf9
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/in-memory-network
branch
2 times, most recently
from
December 21, 2023 21:09
efab202
to
12f1041
Compare
bryanchriswhite
force-pushed
the
issues/141/feat/in-memory-network
branch
from
December 22, 2023 12:28
11c019d
to
f03177e
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/in-memory-network
branch
2 times, most recently
from
December 22, 2023 14:12
438c8a0
to
40df084
Compare
bryanchriswhite
force-pushed
the
issues/141/feat/in-memory-network
branch
from
December 22, 2023 14:12
f03177e
to
a2e53c1
Compare
This was referenced Dec 22, 2023
bryanchriswhite
force-pushed
the
issues/141/refactor/in-memory-network
branch
2 times, most recently
from
January 2, 2024 08:45
c8f623d
to
a679165
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/in-memory-network
branch
2 times, most recently
from
January 2, 2024 12:52
92fad70
to
8bad7dd
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/in-memory-network
branch
from
January 2, 2024 12:58
8bad7dd
to
2b1158a
Compare
…ctor/in-memory-network * issues/141/feat/in-memory-network: fixup! fix: linter errors
Olshansk
requested changes
Jan 5, 2024
…ctor/in-memory-network * issues/141/feat/in-memory-network: chore: fix comment typo chore: post-merge refactor chore: fix comment chore: add #GetConfig() chore: rename InMemoryCosmosNetwork to InMemoryNetwork chore: update comment chore: review feedback improvements chore: add TODOs [Docs] Load Test #1 - Plan (#286) [Bug] Fix observable error logging (#298) [docs] Relayminer config documentation (#288) [Configs] Add foundation for RelayMiner operation configs. (#284) [SMT] Update to use SMT v0.8.2 (#297) [EventsReplayClient] Fix Replay Client Bugs (#267)
h5law
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment on naming confusion as we use an SDK and provide an SDK
Otherwise great refactoring!
Love the new pattern, this is truly 🔥:
memnet := sessionnet.NewInMemoryNetworkWithSessions(
t, &network.InMemoryNetworkConfig{
NumSuppliers: 2,
AppSupplierPairingRatio: appSupplierPairingRatio,
},
)
memnet.Start(ctx, t)
net := memnet.GetNetwork(t)
bryanchriswhite
merged commit Jan 9, 2024
469a83f
into
issues/141/feat/in-memory-network
4 of 5 checks passed
Unintentionally closed, will re-open as a new PR. UPDATE: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Refactors usage of in-memory network in tests to utilize updated in-memory network testutils.
Issue
SubmitProof
message handling #141Type of change
Select one or more:
Testing
make go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist