[Tokenomics] Post-scaffold cleanup & parameter updates foundation #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olshansk
added
protocol
Olshansk
force-pushed
the
issues/243/update_tokenomics_module
branch
from
e327dd5 to
86cca4f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Olshansk
changed the title
…ld message update-params --module tokenomics --yes
…with authz delegation
|
@bryanchriswhite @red-0ne Please see the updated PR description. Replied to most comments and just left a couple open. |
red-0ne
approved these changes
Jan 22, 2024
Co-authored-by: Redouane Lakrache <[email protected]>
Intentionally not merging main.
Co-authored-by: Daniel Olshansky <[email protected]>
There was a problem hiding this comment.
Preemptively approving. I think we should prefer to reference the nft and/or group modules as examples of modern cosmos-sdk best practices as they are the newest.
(see: #287 (comment))
bryanchriswhite
approved these changes
Jan 23, 2024
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use |
github-actions
bot
added
devnet
push-image
|
@bryanchriswhite Missed your last comment but I made the update directly on main: f8b44a2 |
bryanchriswhite
removed
push-image
okdas
added a commit
that referenced
this pull request
Nov 14, 2024
- Scaffolded the `MsgUpdateParams` in the `tokenomics` module with tests - Researched `x/gov`, `x/upgrade` and `x/authz` to set a pattern that follows Cosmos SDK best practices for governance parameter maintenance - Reviewers: Please look through the description in this ticket to get some context as well #322 - Deferring all imports and lining errors to the tooling we have today: `make go_lint && make go_imports` - A few minor documentation NITs outside the scope of this PR that made it in accidently --- Co-authored-by: Redouane Lakrache <[email protected]> Co-authored-by: Dima Kniazev <[email protected]> Co-authored-by: Bryan White <[email protected]>
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MsgUpdateParamsin thetokenomicsmodule with testsx/gov,x/upgradeandx/authzto set a pattern that follows Cosmos SDK best practicesfor governance parameter maintenance
make go_lint && make go_importsIssue
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist